Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of Date RapidJSON dependency causing compile failure #120

Closed
juniperfdel opened this issue May 10, 2024 · 2 comments
Closed

Out of Date RapidJSON dependency causing compile failure #120

juniperfdel opened this issue May 10, 2024 · 2 comments

Comments

@juniperfdel
Copy link

The RapidJSON dependency in the source tree is out of date and the following issue is preventing compilation using new compilers.

Tencent/rapidjson#2277

@mpatrascoiu
Copy link
Contributor

Hello,

The merge request #119 should address this.
Will be released in Davix v0.8.7.

Cheers,
Mihai

@mpatrascoiu
Copy link
Contributor

mpatrascoiu commented Dec 4, 2024

Hello,

In fact, I was wrong and the merge request #119 did not in fact address this issue.
The issue was reported again in #130 (previously to that, a fix was submitted in #129).

By now, #129 was merged and the situation should be addressed.

I'm also tracking this issue internally:

  • DMC-1426: Remove dependency on RapidJSON from the Davix codebase
  • DMC-1427: Davix should always use the bundled RapidJson library

Over the long-term, the project should move away from depending on RapidJson.

Hope this time we can consider this issue closed.

Cheers,
Mihai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants