Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Themeable Properties needs to take in a selector of options for React 16 #47

Closed
1 of 4 tasks
JakeLaCombe opened this issue Jan 22, 2018 · 1 comment
Closed
1 of 4 tasks

Themeable Properties needs to take in a selector of options for React 16 #47

JakeLaCombe opened this issue Jan 22, 2018 · 1 comment

Comments

@JakeLaCombe
Copy link
Contributor

JakeLaCombe commented Jan 22, 2018 •
edited
Loading

Issue Description

React 16 no longer adds data-reactroot to the application. This invalidates all tests that rely on that element being present.

From looking at facebook/react#10971, it sounds like the solution is just to specify id's and classnames to attach to for checking screenshots. Given that, we should add an options argument to be passed into the webdriver.io service.

Issue Type

  • New Feature
  • Enhancement
  • Bug
  • Other
@JakeLaCombe JakeLaCombe changed the title Default wdio selector won't work for React 16. Themeable Properties needs to take in a selector of options for React 16 Jan 22, 2018
@JakeLaCombe
Copy link
Contributor Author

Closed here. #48

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JakeLaCombe