-
Notifications
You must be signed in to change notification settings - Fork 13
/
Copy pathmanager.go
507 lines (436 loc) · 15.9 KB
/
manager.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
/*
Copyright 2021 The cert-manager Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package manager
import (
"context"
"errors"
"fmt"
"sort"
"sync"
"time"
"github.com/go-logr/logr"
apiutil "github.com/jetstack/cert-manager/pkg/api/util"
cmapi "github.com/jetstack/cert-manager/pkg/apis/certmanager/v1"
cmclient "github.com/jetstack/cert-manager/pkg/client/clientset/versioned"
cminformers "github.com/jetstack/cert-manager/pkg/client/informers/externalversions"
cmlisters "github.com/jetstack/cert-manager/pkg/client/listers/certmanager/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/selection"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/uuid"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/utils/clock"
internalapi "github.com/cert-manager/csi-lib/internal/api"
internalapiutil "github.com/cert-manager/csi-lib/internal/api/util"
"github.com/cert-manager/csi-lib/metadata"
"github.com/cert-manager/csi-lib/storage"
)
// Options used to construct a Manager
type Options struct {
// Client used to interact with the cert-manager API
Client cmclient.Interface
// Used the read metadata from the storage backend
MetadataReader storage.MetadataReader
// Clock used to determine when an issuance is due.
// If not set, the RealClock implementation will be used.
Clock clock.Clock
// Logger used to write log messages
Log logr.Logger
// Maximum number of CertificateRequests that should exist for each
// volume mounted into a pod.
// If not set, this will be defaulted to 1.
// When the number of CertificateRequests for a volume exceeds this limit,
// requests will be deleted before any new ones are created.
MaxRequestsPerVolume int
// NodeID is a unique identifier for the node.
NodeID string
GeneratePrivateKey GeneratePrivateKeyFunc
GenerateRequest GenerateRequestFunc
SignRequest SignRequestFunc
WriteKeypair WriteKeypairFunc
}
// NewManager constructs a new manager used to manage volumes containing
// certificate data.
// It will enumerate all volumes already persisted in the metadata store and
// resume managing them if any already exist.
func NewManager(opts Options) (*Manager, error) {
if opts.Client == nil {
return nil, errors.New("Client must be set")
}
if opts.Clock == nil {
opts.Clock = clock.RealClock{}
}
if opts.Log == nil {
return nil, errors.New("Log must be set")
}
if opts.MetadataReader == nil {
return nil, errors.New("MetadataReader must be set")
}
if opts.GeneratePrivateKey == nil {
return nil, errors.New("GeneratePrivateKey must be set")
}
if opts.GenerateRequest == nil {
return nil, errors.New("GenerateRequest must be set")
}
if opts.SignRequest == nil {
return nil, errors.New("SignRequest must be set")
}
if opts.WriteKeypair == nil {
return nil, errors.New("WriteKeypair must be set")
}
if opts.MaxRequestsPerVolume == 0 {
opts.MaxRequestsPerVolume = 1
}
if opts.MaxRequestsPerVolume < 0 {
return nil, errors.New("MaxRequestsPerVolume cannot be less than zero")
}
if len(opts.NodeID) == 0 {
return nil, errors.New("NodeID must be set")
}
nodeNameHash := internalapiutil.HashIdentifier(opts.NodeID)
nodeNameReq, err := labels.NewRequirement(internalapi.NodeIDHashLabelKey, selection.Equals, []string{nodeNameHash})
if err != nil {
return nil, fmt.Errorf("building node name label selector: %w", err)
}
// Create an informer factory
informerFactory := cminformers.NewSharedInformerFactoryWithOptions(opts.Client, 0, cminformers.WithTweakListOptions(func(opts *metav1.ListOptions) {
opts.LabelSelector = labels.NewSelector().Add(*nodeNameReq).String()
}))
// Fetch the lister before calling Start() to ensure this informer is
// registered with the factory
lister := informerFactory.Certmanager().V1().CertificateRequests().Lister()
stopCh := make(chan struct{})
// Begin watching the API
informerFactory.Start(stopCh)
informerFactory.WaitForCacheSync(stopCh)
m := &Manager{
client: opts.Client,
lister: lister,
metadataReader: opts.MetadataReader,
clock: opts.Clock,
log: opts.Log,
generatePrivateKey: opts.GeneratePrivateKey,
generateRequest: opts.GenerateRequest,
signRequest: opts.SignRequest,
writeKeypair: opts.WriteKeypair,
managedVolumes: map[string]chan struct{}{},
stopInformer: stopCh,
maxRequestsPerVolume: opts.MaxRequestsPerVolume,
nodeNameHash: nodeNameHash,
}
vols, err := opts.MetadataReader.ListVolumes()
if err != nil {
return nil, fmt.Errorf("listing existing volumes: %w", err)
}
for _, vol := range vols {
m.log.Info("Registering existing data directory for management", "volume", vol)
if err := m.ManageVolume(vol); err != nil {
return nil, fmt.Errorf("loading existing volume: %w", err)
}
}
return m, nil
}
func NewManagerOrDie(opts Options) *Manager {
m, err := NewManager(opts)
if err != nil {
panic("failed to start manager: " + err.Error())
}
return m
}
// A Manager will manage key pairs in a storage backend.
// It is responsible for:
// * Generating private key data
// * Generating certificate requests (CSRs)
// * Submitting certificate requests
// * Waiting for requests to be completed
// * Persisting the keys back to the storage backend
//
// It also will trigger renewals of certificates when required.
type Manager struct {
// client used to create & delete objects in the cert-manager API
client cmclient.Interface
// lister is used as a read-only cache of CertificateRequest resources
lister cmlisters.CertificateRequestLister
// used to read metadata from the store
metadataReader storage.MetadataReader
log logr.Logger
clock clock.Clock
// User-configurable functions used to customise behaviour
generatePrivateKey GeneratePrivateKeyFunc
generateRequest GenerateRequestFunc
signRequest SignRequestFunc
writeKeypair WriteKeypairFunc
lock sync.Mutex
// global view of all volumes managed by this manager
// the stored channel is used to stop management of the
// volume
managedVolumes map[string]chan struct{}
// Used to stop the informer watching for updates
stopInformer chan struct{}
// hash of the node name this driver is running on, used to label CertificateRequest
// resources to allow the lister to be scoped to requests for this node only
nodeNameHash string
// maximum number of CertificateRequests that should exist at any time for each volume
maxRequestsPerVolume int
}
// issue will step through the entire issuance flow for a volume.
func (m *Manager) issue(volumeID string) error {
ctx := context.TODO()
log := m.log.WithValues("volume_id", volumeID)
log.Info("Processing issuance")
if err := m.cleanupStaleRequests(ctx, log, volumeID); err != nil {
return fmt.Errorf("cleaning up stale requests: %w", err)
}
meta, err := m.metadataReader.ReadMetadata(volumeID)
if err != nil {
return fmt.Errorf("reading metadata: %w", err)
}
log.V(2).Info("Read metadata", "metadata", meta)
key, err := m.generatePrivateKey(meta)
if err != nil {
return fmt.Errorf("generating private key: %w", err)
}
log.V(2).Info("Obtained new private key")
csrBundle, err := m.generateRequest(meta)
if err != nil {
return fmt.Errorf("generating certificate signing request: %w", err)
}
log.V(2).Info("Constructed new CSR")
csrPEM, err := m.signRequest(meta, key, csrBundle.Request)
if err != nil {
return fmt.Errorf("signing certificate signing request: %w", err)
}
log.V(2).Info("Signed CSR")
req, err := m.submitRequest(ctx, meta, csrBundle, csrPEM)
if err != nil {
return fmt.Errorf("submitting request: %w", err)
}
log.Info("Created new CertificateRequest resource")
// Poll every 1s for the CertificateRequest to be ready
if err := wait.PollUntil(time.Second, func() (done bool, err error) {
updatedReq, err := m.lister.CertificateRequests(req.Namespace).Get(req.Name)
if apierrors.IsNotFound(err) {
// A NotFound error implies something deleted the resource - fail
// early to allow a retry to occur at a later time if needed.
return false, err
}
if err != nil {
log.Error(err, "Failed fetch CertificateRequest")
// TODO: it'd probably be better to log transient errors and retry
// the Get to better handle cases where the apiserver is
// intermittently unavailable but otherwise the API works.
return false, err
}
// Handle cases where the request has been explicitly denied
if apiutil.CertificateRequestIsDenied(updatedReq) {
cond := apiutil.GetCertificateRequestCondition(updatedReq, cmapi.CertificateRequestConditionDenied)
return false, fmt.Errorf("request %q has been denied by the approval plugin: %s", updatedReq.Name, cond.Message)
}
readyCondition := apiutil.GetCertificateRequestCondition(updatedReq, cmapi.CertificateRequestConditionReady)
if readyCondition == nil {
log.V(2).Info("CertificateRequest is still pending")
// Issuance is still pending
return false, nil
}
switch readyCondition.Reason {
case cmapi.CertificateRequestReasonIssued:
break
case cmapi.CertificateRequestReasonFailed:
return false, fmt.Errorf("request %q has failed: %s", updatedReq.Name, readyCondition.Message)
case cmapi.CertificateRequestReasonPending:
log.V(2).Info("CertificateRequest is still pending")
return false, nil
default:
log.Info("unrecognised state for Ready condition", "request_namespace", updatedReq.Namespace, "request_name", updatedReq.Name, "condition", *readyCondition)
return false, nil
}
// if issuance is complete, set req to the updatedReq and continue to
log.V(2).Info("CertificateRequest completed and issued successfully")
// writing out signed certificate
req = updatedReq
return true, nil
}, ctx.Done()); err != nil {
return fmt.Errorf("waiting for request: %w", err)
}
if err := m.writeKeypair(meta, key, req.Status.Certificate, req.Status.CA); err != nil {
return fmt.Errorf("writing keypair: %w", err)
}
log.V(2).Info("Wrote new keypair to storage")
return nil
}
func (m *Manager) cleanupStaleRequests(ctx context.Context, log logr.Logger, volumeID string) error {
sel, err := m.labelSelectorForVolume(volumeID)
if err != nil {
return fmt.Errorf("internal error building label selector - this is a bug, please open an issue: %w", err)
}
reqs, err := m.lister.List(sel)
if err != nil {
return fmt.Errorf("listing certificaterequests: %w", err)
}
if len(reqs) < m.maxRequestsPerVolume {
return nil
}
// sort newest first to oldest last
sort.Slice(reqs, func(i, j int) bool {
return reqs[i].CreationTimestamp.After(reqs[j].CreationTimestamp.Time)
})
// start at the end of the slice and work back to maxRequestsPerVolume
for i := len(reqs) - 1; i >= m.maxRequestsPerVolume-1; i-- {
toDelete := reqs[i]
if err := m.client.CertmanagerV1().CertificateRequests(toDelete.Namespace).Delete(ctx, toDelete.Name, metav1.DeleteOptions{}); err != nil {
if apierrors.IsNotFound(err) {
// don't fail if the resource is already deleted
} else {
return fmt.Errorf("deleting old certificaterequest: %w", err)
}
}
log.Info("Deleted CertificateRequest resource", "name", toDelete.Name, "namespace", toDelete.Namespace)
}
return nil
}
func (m *Manager) labelSelectorForVolume(volumeID string) (labels.Selector, error) {
sel := labels.NewSelector()
req, err := labels.NewRequirement(internalapi.NodeIDHashLabelKey, selection.Equals, []string{m.nodeNameHash})
if err != nil {
return nil, err
}
sel.Add(*req)
req, err = labels.NewRequirement(internalapi.VolumeIDHashLabelKey, selection.Equals, []string{internalapiutil.HashIdentifier(volumeID)})
if err != nil {
return nil, err
}
sel.Add(*req)
return sel, nil
}
// submitRequest will create a CertificateRequest resource and return the
// created resource.
func (m *Manager) submitRequest(ctx context.Context, meta metadata.Metadata, csrBundle *CertificateRequestBundle, csrPEM []byte) (*cmapi.CertificateRequest, error) {
req := &cmapi.CertificateRequest{
ObjectMeta: metav1.ObjectMeta{
Name: string(uuid.NewUUID()),
Namespace: csrBundle.Namespace,
Annotations: csrBundle.Annotations,
Labels: map[string]string{
internalapi.NodeIDHashLabelKey: m.nodeNameHash,
internalapi.VolumeIDHashLabelKey: internalapiutil.HashIdentifier(meta.VolumeID),
},
OwnerReferences: []metav1.OwnerReference{
{
APIVersion: "core/v1",
Kind: "Pod",
Name: meta.VolumeContext["csi.storage.k8s.io/pod.name"],
UID: types.UID(meta.VolumeContext["csi.storage.k8s.io/pod.uid"]),
},
},
},
Spec: cmapi.CertificateRequestSpec{
Request: csrPEM,
IssuerRef: csrBundle.IssuerRef,
Duration: &metav1.Duration{Duration: csrBundle.Duration},
IsCA: csrBundle.IsCA,
Usages: csrBundle.Usages,
},
}
req, err := m.client.CertmanagerV1().CertificateRequests(csrBundle.Namespace).Create(ctx, req, metav1.CreateOptions{})
if err != nil {
return nil, err
}
// Wait to ensure the lister has observed the creation of the CertificateRequest
// This ensures callers that read from the lister/cache do not enter a confused state
// where the CertificateRequest does not exist after calling submitRequest due to
// cache timing issues.
wait.PollUntil(time.Millisecond*50, func() (bool, error) {
_, err := m.lister.CertificateRequests(csrBundle.Namespace).Get(req.Name)
if apierrors.IsNotFound(err) {
return false, nil
}
if err != nil {
return false, err
}
return true, nil
}, ctx.Done())
return req, nil
}
// ManageVolume will initiate management of data for the given volumeID.
func (m *Manager) ManageVolume(volumeID string) error {
m.lock.Lock()
defer m.lock.Unlock()
log := m.log.WithValues("volume_id", volumeID)
// if the volume is already managed, return early
if _, ok := m.managedVolumes[volumeID]; ok {
log.V(2).Info("Volume already registered for management")
return nil
}
// construct a new channel used to stop management of the volume
stopCh := make(chan struct{})
m.managedVolumes[volumeID] = stopCh
go func() {
// check every volume once per second
// TODO: optimise this to not check so often
ticker := time.NewTicker(time.Second)
for {
select {
case <-stopCh:
// management of this volume has been stopped, exit the goroutine
return
case <-ticker.C:
meta, err := m.metadataReader.ReadMetadata(volumeID)
if err != nil {
log.Error(err, "Failed to read metadata")
continue
}
if meta.NextIssuanceTime == nil || m.clock.Now().After(*meta.NextIssuanceTime) {
log.Info("Triggering new issuance")
if err := m.issue(volumeID); err != nil {
log.Error(err, "Failed to issue certificate")
// retry the request in 1 second time
// TODO: exponentially back-off
continue
}
}
}
}
}()
return nil
}
func (m *Manager) UnmanageVolume(volumeID string) {
m.lock.Lock()
defer m.lock.Unlock()
if stopCh, ok := m.managedVolumes[volumeID]; ok {
close(stopCh)
delete(m.managedVolumes, volumeID)
}
}
func (m *Manager) IsVolumeReady(volumeID string) bool {
meta, err := m.metadataReader.ReadMetadata(volumeID)
if err != nil {
m.log.Error(err, "failed to read metadata", "volume_id", volumeID)
return false
}
if meta.NextIssuanceTime == nil || m.clock.Now().After(*meta.NextIssuanceTime) {
return false
}
return true
}
// Stop will stop management of all managed volumes
func (m *Manager) Stop() {
m.lock.Lock()
defer m.lock.Unlock()
close(m.stopInformer)
for k, stopCh := range m.managedVolumes {
close(stopCh)
delete(m.managedVolumes, k)
}
}