Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-update branch: commit should happen only if certificates have changed #29

Open
dolmen opened this issue Sep 21, 2021 · 2 comments · May be fixed by #32
Open

test-update branch: commit should happen only if certificates have changed #29

dolmen opened this issue Sep 21, 2021 · 2 comments · May be fixed by #32

Comments

@dolmen
Copy link
Contributor

dolmen commented Sep 21, 2021

It is not helpful to have automated commits of regeneration where no certificates changes happened, but instead only timestamp changes.

So the Github Actions workflow should check that the diff has at least more than 2 lines that changed.

@mattrobenolt
Copy link
Member

Yeah, my plan was to just keep a file that was the hash of the certificate content, and compare to that on each run. Similar idea, and a bit better of a test than checking number of changed lines.

I just haven't had any motivation to do it to be honest.

@tmm1
Copy link
Contributor

tmm1 commented Jul 21, 2022

Friendly ping

@edigaryev edigaryev linked a pull request Jun 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants