-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shield: implement distribution params #380
Conversation
* added upgrade handler to yoongbooks pr shield: implement distirbution params * remove unwanted spaces * fix imports * remove unwanted comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logically LGTM.
Seems test case TestBeginBlocker
panicked.
=== RUN TestBeginBlocker/normal --- FAIL: TestBeginBlocker (0.04s) --- FAIL: TestBeginBlocker/normal (0.00s) panic: invalid coin denominations; stake, uctk [recovered] panic: invalid coin denominations; stake, uctk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, how do we test upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 47.46% 48.83% +1.36%
==========================================
Files 102 110 +8
Lines 8258 8550 +292
==========================================
+ Hits 3920 4175 +255
+ Misses 3927 3921 -6
- Partials 411 454 +43
|
Closes: #379
Related: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)