Remove (not available) if no PID agency #156
Comments
|
Original comment by John Shepherdson (GitHub: john-shepherdson). Trivial change, does not require UI expert. |
|
Original comment by Taina Jääskeläinen. Checked the dev version. The meaning was to remove the notice about no agency information available altogether. So with agency information, it should be (like currently): 10.5279/DK-SA-DDA-868 (DDA) If no agency information, it should be: 10.5279/DK-SA-DDA-868 Currently the system says, if no agency information: 10.5279/DK-SA-DDA-868 (Agency not available) |
|
Original comment by John Shepherdson (GitHub: john-shepherdson). Understood, but ‘not available’ is used in the Language, Agency and Date fields, so rather than remove it from one, I updated the strings to be more specific, hence ‘Language not available', ‘Agency not available’ and 'Date not available’ |
|
Original comment by John Shepherdson (GitHub: john-shepherdson). User group decided that they would rather have no label than ‘Agency not available’. If it cannot be removed in the short-term, it should be changed to ‘Agency not specified’ |
|
Original comment by John Shepherdson (GitHub: john-shepherdson). It is more complex that it appears to remove ‘Agency not available’. So it has been replaced with 'Agency not specified’. Same goes for Date, Publisher and Country. Other fields use a generic ‘Not specified’ value. This can be seen on the current staging build. |
|
Original comment by Taina Jääskeläinen. See #235 for what to have for the other fields than PID agency when there is no information available. Daniel to take a look if (Agency not specified) can be removed with reasonable effort. |
|
Original comment by Matthew Morris (GitHub: matthew-morris-cessda). [link to pull request removed](link to pull request removed) [link to pull request removed](link to pull request removed) [link to pull request removed](link to pull request removed) |
|
Original comment by Matthew Morris (GitHub: matthew-morris-cessda). The PRs have been merged. The changes should be visible on dev and staging. The staging index has also been cleared to remove stale data. |
|
Original comment by John Shepherdson (GitHub: john-shepherdson). Unable to find an example at random that demonstrates the fix. |
|
Original comment by Matthew Morris (GitHub: matthew-morris-cessda). https://datacatalogue-staging.cessda.eu/detail?q="APIS__APIS0060" |
Original report on BitBucket by Taina Jääskeläinen.
If a ID (study number or Study PID) element does not have the agency information, do not display in the UI (not available), as this is confusing for users. They think the identifier is not available and wonder why they still an see it.
The text was updated successfully, but these errors were encountered: