Sort order label translations are not being applied

[cessda-bitbucket-importer]

Original report on BitBucket by John Shepherdson (GitHub: john-shepherdson).

---

Instead the keys are being displayed.

relevance: 'Relevance',
    titleAscending: 'Title (A - Z)',
    titleDescending: 'Title (Z - A)',
    dateAscending: 'Date of collection (oldest)',
    dateDescending: 'Date of collection (newest)'

‌

[cessda-bitbucket-importer]

Original comment by Matthew Morris (GitHub: matthew-morris-cessda).

---

This was caused by translations not being set up properly.

Translations were originally applied in SortingSelector.jsx using an override that modified the internals of SearchkitSortingSelector directly. The internals were changed in an update, necessitating changing how translations were applied.

export class SortingSelector extends SearchkitSortingSelector<Props> {
  render(): Node {
    _.map(this.accessor.options.options, (option: Object): Object => {
      option.label = counterpart.translate(option.translation);
      return option;
    });
  }
}

Translations are now applied in TopBar.jsx by applying the change to the label field when the components are being declared.

<SortingSelector className="level-item" options={[{
  label: counterpart.translate('sorting.relevance'),
  key: 'relevance',
  field: '_score',
  order: 'desc',
  defaultOption: true
}, {
  label: counterpart.translate('sorting.titleAscending'),
  key: 'title-ascending',
  field: 'titleStudy.raw',
  order: 'asc',
  defaultOption: false
}, {
  label: counterpart.translate('sorting.titleDescending'),
  key: 'title-descending',
  field: 'titleStudy.raw',
  order: 'desc',
  defaultOption: false
}, {
  label: counterpart.translate('sorting.dateAscending'),
  key: 'date-ascending',
  field: 'dataCollectionPeriodStartdate',
  order: 'asc',
  defaultOption: false
}, {
  label: counterpart.translate('sorting.dateDescending'),
  key: 'date-descending',
  field: 'dataCollectionPeriodStartdate',
  order: 'desc',
  defaultOption: false
}]}/>

‌

[cessda-bitbucket-importer]

Original comment by John Shepherdson (GitHub: john-shepherdson).

---

Translations restored in DEV and STAGING