-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor corrections to Ex5.10, S9.5 & App F #186
Comments
Example 5.10: http://cfconventions.org/cf-conventions/cf-conventions.html#british-national-grid Section 9.5: http://cfconventions.org/cf-conventions/cf-conventions.html#coordinates-metadata Table F.1 doesn't have an appendix entry... |
@dblodgett-usgs If the variable is not named with its dimension it is, by definition, an auxiliary coordinate variable, even if it is 1D. This is also true if it is not monotonic. Example H.2 is a case in point. The station_name variable is not a coordinate variable. I think @RosalynHatcher's proposal is good. |
👍 Got it. That makes sense. @RosalynHatcher -- want to open a PR? |
@dblodgett-usgs - Yes I'll open a PR |
Example 5.10 also has
That probably should be Similarly, example 5.6 has
I assume the last line should be Since the PR is still open, I hope this can be corrected in addition to the other fixes? |
@RosalynHatcher -- do you want to add these fixes to your open PR? |
@dblodgett-usgs: Yes I will do. |
Closed with #189 |
A few inconsistencies:
Example 5.10:
;
on lines 8 & 12Section 9.5:
cf_role
attribute is only allowed on coordinate variables by table in Appendix A. I think paragraph 2 in 9.5 should say "Where feasible a coordinate or auxiliary coordinate variable with the attribute cf_role should be included."Appendix F:
grid_mapping_name
should be type 'S' not Numeric.Happy to create a PR if people agree with this.
Cheers,
Ros.
The text was updated successfully, but these errors were encountered: