Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle underscores in sample sheet parsing #1005

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Correctly handle underscores in sample sheet parsing #1005

merged 3 commits into from
Jul 10, 2024

Conversation

Donaim
Copy link
Member

@Donaim Donaim commented Aug 28, 2023 •
edited
Loading

Closes #888

@Donaim Donaim marked this pull request as ready for review August 28, 2023 22:37
@Donaim Donaim force-pushed the samplesheetparser branch from 618b892 to 0121ba5 Compare August 28, 2023 22:42
@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (a8692dc) 86.43% compared to head (3da5255) 86.43%.
Report is 7 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1005   +/-   ##
=======================================
  Coverage   86.43%   86.43%           
=======================================
  Files          28       28           
  Lines        6110     6110           
=======================================
  Hits         5281     5281           
  Misses        829      829

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Donaim Donaim marked this pull request as draft March 11, 2024 19:06
@Donaim Donaim modified the milestones: near future, far future Mar 11, 2024
@Donaim Donaim changed the title Add a failing test for sample sheet parser Correctly handle underscores in sample sheet parsing Jul 10, 2024
@Donaim Donaim changed the base branch from master to release-v7.17.1 July 10, 2024 19:37
@Donaim Donaim force-pushed the release-v7.17.1 branch from 9472ae1 to 06a1064 Compare July 10, 2024 19:38
@Donaim Donaim force-pushed the samplesheetparser branch 2 times, most recently from b390f7f to 59cdb0b Compare July 10, 2024 20:09
Donaim added 3 commits July 10, 2024 13:27
@Donaim
Add a failing test for sample sheet parser
a69f035 
This case tests the behaviour described in #888

When the issue is solved, we should unmark this case as "Failure".
@Donaim
Make samplesheet parser tolerable to underscores in enum names
6e452f2 
Solves #888
@Donaim
Add more tests for sample sheet parsing with underscores
c9c6dee
@Donaim Donaim force-pushed the samplesheetparser branch from 59cdb0b to a69f035 Compare July 10, 2024 20:29
@Donaim Donaim marked this pull request as ready for review July 10, 2024 20:45
@Donaim Donaim merged commit 8d0a52c into release-v7.17.1 Jul 10, 2024
2 checks passed
@Donaim Donaim deleted the samplesheetparser branch July 10, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
near future
Development

Successfully merging this pull request may close these issues.

Sample sheet parser fails when enum contains an underscore
1 participant
@Donaim