From 8dfe18a012086a0abb518541a1425ba538f72858 Mon Sep 17 00:00:00 2001 From: ryaneberly Date: Sat, 12 Aug 2017 18:50:33 -0400 Subject: [PATCH] #416 fixed. --- src/main/java/com/cflint/CFLint.java | 5 +++++ src/test/java/com/cflint/TestUnusedLocalVarChecker.java | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/cflint/CFLint.java b/src/main/java/com/cflint/CFLint.java index 0efca8098..876cdf341 100644 --- a/src/main/java/com/cflint/CFLint.java +++ b/src/main/java/com/cflint/CFLint.java @@ -525,6 +525,11 @@ private void process(final Element elem, final String space, final Context conte } } else if (elem.getName().equalsIgnoreCase("cfqueryparam")) { scanElement(elem, context); + for(final Entry expression : unpackTagExpressions(elem).entrySet()){ + if (expression != null) { + process(expression.getValue(), elem, context); + } + } } else if (elem.getName().equalsIgnoreCase("cfinclude")) { scanElement(elem, context); final String path = elem.getAttributeValue("template"); diff --git a/src/test/java/com/cflint/TestUnusedLocalVarChecker.java b/src/test/java/com/cflint/TestUnusedLocalVarChecker.java index c8633207f..b4f2a3cc5 100644 --- a/src/test/java/com/cflint/TestUnusedLocalVarChecker.java +++ b/src/test/java/com/cflint/TestUnusedLocalVarChecker.java @@ -1,6 +1,7 @@ package com.cflint; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; import java.io.IOException; import java.util.List; @@ -253,7 +254,6 @@ public void testMultipleUnusedVarFunctionInTag() throws ParseException, IOExcept @Test - @Ignore public void testUsedVarInQuaryParam() throws ParseException, IOException { final String tagSrc = "\r\n" + "\r\n" @@ -269,9 +269,9 @@ public void testUsedVarInQuaryParam() throws ParseException, IOException { + "\r\n" + ""; - cfBugs.process(tagSrc, "test"); + cfBugs.process(tagSrc, "test"); final List result = cfBugs.getBugs().getBugList().get("UNUSED_LOCAL_VARIABLE"); - assertEquals(0, result.size()); + assertTrue(result == null); } }