From b00e09c39f083fea1ff56f666dce1970f31f9dce Mon Sep 17 00:00:00 2001 From: Justin Mclean Date: Sun, 20 Aug 2017 11:08:36 +1000 Subject: [PATCH] add missing final to method arguments --- src/main/java/com/cflint/CFLintStats.java | 6 ++--- src/main/java/com/cflint/Levels.java | 4 ++-- .../cflint/config/CFLintChainedConfig.java | 16 +++++++------- .../java/com/cflint/config/CFLintConfig.java | 4 ++-- src/main/java/com/cflint/main/CFLintMain.java | 2 +- .../plugins/CFLintStructureListener.java | 12 +++++----- .../plugins/core/ArgDefConditionChecker.java | 2 +- .../cflint/plugins/core/ArgHintChecker.java | 2 +- .../plugins/core/ComponentHintChecker.java | 2 +- .../plugins/core/FunctionHintChecker.java | 2 +- .../cflint/plugins/core/LiteralChecker.java | 2 +- .../plugins/core/PackageCaseChecker.java | 8 +++---- .../plugins/core/SimpleComplexityChecker.java | 2 +- .../plugins/core/TooManyFunctionsChecker.java | 2 +- .../plugins/core/UnusedArgumentChecker.java | 2 +- .../plugins/core/UnusedLocalVarChecker.java | 8 +++---- .../plugins/core/VariableNameChecker.java | 4 ++-- .../com/cflint/tools/CommentReformatting.java | 2 +- .../java/com/cflint/tools/ObjectEquals.java | 2 +- .../cflint/tools/PrecedingCommentReader.java | 2 +- .../com/cflint/xml/MarshallerException.java | 6 ++--- .../stax/DefaultCFlintResultMarshaller.java | 22 +++++++++---------- 22 files changed, 57 insertions(+), 57 deletions(-) diff --git a/src/main/java/com/cflint/CFLintStats.java b/src/main/java/com/cflint/CFLintStats.java index 975303d5d..8bcc92cf5 100644 --- a/src/main/java/com/cflint/CFLintStats.java +++ b/src/main/java/com/cflint/CFLintStats.java @@ -17,14 +17,14 @@ public CFLintStats() { super(); } - public CFLintStats(long timestamp, long fileCount, BigInteger totalLines) { + public CFLintStats(final long timestamp, long fileCount, BigInteger totalLines) { super(); this.timestamp = timestamp; this.fileCount = fileCount; this.totalLines = totalLines; } - public CFLintStats(long timestamp, long fileCount, BigInteger totalLines, BugCounts counts) { + public CFLintStats(final long timestamp, long fileCount, BigInteger totalLines, BugCounts counts) { super(); this.timestamp = timestamp; this.fileCount = fileCount; @@ -32,7 +32,7 @@ public CFLintStats(long timestamp, long fileCount, BigInteger totalLines, BugCou this.counts = counts; } - public void addFile(long numberOfLines){ + public void addFile(final long numberOfLines){ fileCount++; totalLines = totalLines.add(BigInteger.valueOf(numberOfLines)); } diff --git a/src/main/java/com/cflint/Levels.java b/src/main/java/com/cflint/Levels.java index 89ef3add3..37914f51b 100644 --- a/src/main/java/com/cflint/Levels.java +++ b/src/main/java/com/cflint/Levels.java @@ -12,7 +12,7 @@ public enum Levels { private final String severity; - private Levels(String name) { + private Levels(final String name) { severity = name; } @@ -25,7 +25,7 @@ public String toString() { return this.severity; } - public static Levels fromString(String severity) { + public static Levels fromString(final String severity) { for (Levels level : Levels.values()) { if (level.toString().equals(severity)) { return level; diff --git a/src/main/java/com/cflint/config/CFLintChainedConfig.java b/src/main/java/com/cflint/config/CFLintChainedConfig.java index d3cf64cab..e37d0b89f 100644 --- a/src/main/java/com/cflint/config/CFLintChainedConfig.java +++ b/src/main/java/com/cflint/config/CFLintChainedConfig.java @@ -12,13 +12,13 @@ public class CFLintChainedConfig implements CFLintConfiguration { final private CFLintConfig config; final private CFLintConfiguration parent; - public CFLintChainedConfig(CFLintConfiguration config) { + public CFLintChainedConfig(final CFLintConfiguration config) { super(); this.config = (CFLintConfig) config; parent = null; } - public CFLintChainedConfig(CFLintConfiguration config, CFLintConfiguration parent) { + public CFLintChainedConfig(final CFLintConfiguration config, CFLintConfiguration parent) { super(); this.config = (CFLintConfig) config; this.parent = parent; @@ -30,18 +30,18 @@ public CFLintChainedConfig(CFLintConfiguration config, CFLintConfiguration paren * @param config * @return */ - public CFLintChainedConfig createNestedConfig(CFLintConfiguration config) { + public CFLintChainedConfig createNestedConfig(final CFLintConfiguration config) { return config == null ? this : new CFLintChainedConfig(config, this); } @Override - public boolean includes(PluginMessage pluginMessage) { + public boolean includes(final PluginMessage pluginMessage) { return config.includes(pluginMessage) || (config.isInheritParent() && parent != null && parent.includes(pluginMessage)); } @Override - public boolean excludes(PluginMessage pluginMessage) { + public boolean excludes(final PluginMessage pluginMessage) { return config.excludes(pluginMessage) || (config.isInheritParent() && parent != null && parent.excludes(pluginMessage)); } @@ -51,7 +51,7 @@ public CFLintConfiguration getParent() { } @Override - public PluginInfoRule getRuleByClass(Class clazz) { + public PluginInfoRule getRuleByClass(final Class clazz) { PluginInfoRule retval = config.getRuleByClass(clazz); if (retval != null || parent == null) { return retval; @@ -69,12 +69,12 @@ public PluginInfoRule getRuleForPlugin(CFLintScanner plugin) { } @Override - public void addInclude(PluginMessage pluginMessage) { + public void addInclude(final PluginMessage pluginMessage) { config.addInclude(pluginMessage); } @Override - public void addExclude(PluginMessage pluginMessage) { + public void addExclude(final PluginMessage pluginMessage) { config.addExclude(pluginMessage); } diff --git a/src/main/java/com/cflint/config/CFLintConfig.java b/src/main/java/com/cflint/config/CFLintConfig.java index 4cc7226a8..8560b2bda 100644 --- a/src/main/java/com/cflint/config/CFLintConfig.java +++ b/src/main/java/com/cflint/config/CFLintConfig.java @@ -90,7 +90,7 @@ public boolean isInheritParent() { } @XmlAttribute(name = "inheritParent") - public void setInheritParent(boolean inheritParent) { + public void setInheritParent(final boolean inheritParent) { this.inheritParent = inheritParent; } @@ -101,7 +101,7 @@ public boolean isInheritPlugins() { @XmlAttribute(name = "inheritPlugins") @Deprecated - public void setInheritPlugins(boolean inheritPlugins) { + public void setInheritPlugins(final boolean inheritPlugins) { // #315 --- inheritPlugins can not be overwritten to false in 1.2.0 --- will be fully removed in 1.3.0 (but will then break people's setup if the setting remains in .cflintrc or the xml config this.inheritPlugins = true; } diff --git a/src/main/java/com/cflint/main/CFLintMain.java b/src/main/java/com/cflint/main/CFLintMain.java index 62ede9998..9d4467beb 100644 --- a/src/main/java/com/cflint/main/CFLintMain.java +++ b/src/main/java/com/cflint/main/CFLintMain.java @@ -298,7 +298,7 @@ protected static void applyRuleGroups(final CFLintMain main, final CFLintPluginI * * @param pluginInfo */ - private static void listRuleGroups(CFLintPluginInfo pluginInfo) { + private static void listRuleGroups(final CFLintPluginInfo pluginInfo) { Map allCodes = new LinkedHashMap(); for (PluginInfoRule rule : pluginInfo.getRules()) { for (PluginMessage msg : rule.getMessages()) { diff --git a/src/main/java/com/cflint/plugins/CFLintStructureListener.java b/src/main/java/com/cflint/plugins/CFLintStructureListener.java index 65c2795bb..414ab6aed 100644 --- a/src/main/java/com/cflint/plugins/CFLintStructureListener.java +++ b/src/main/java/com/cflint/plugins/CFLintStructureListener.java @@ -21,7 +21,7 @@ public interface CFLintStructureListener { * @param bugs * List of errors reported */ - public void startFile(String fileName, BugList bugs); + public void startFile(final String fileName, BugList bugs); /** * Called when processing of current file has ended @@ -31,7 +31,7 @@ public interface CFLintStructureListener { * @param bugs * List of errors reported */ - public void endFile(String fileName, BugList bugs); + public void endFile(final String fileName, BugList bugs); /** * Called when processing a new component has started @@ -41,7 +41,7 @@ public interface CFLintStructureListener { * @param bugs * List of errors reported */ - public void startComponent(Context context, BugList bugs); + public void startComponent(final Context context, BugList bugs); /** * Called when processing of current component has ended @@ -51,7 +51,7 @@ public interface CFLintStructureListener { * @param bugs * List of errors reported */ - public void endComponent(Context context, BugList bugs); + public void endComponent(final Context context, BugList bugs); /** * Called when processing of a new function has started @@ -61,7 +61,7 @@ public interface CFLintStructureListener { * @param bugs * List of errors reported */ - public void startFunction(Context context, BugList bugs); + public void startFunction(final Context context, BugList bugs); /** * Called when processing of current function has ended @@ -71,6 +71,6 @@ public interface CFLintStructureListener { * @param bugs * List of errors reported */ - public void endFunction(Context context, BugList bugs); + public void endFunction(final Context context, BugList bugs); } diff --git a/src/main/java/com/cflint/plugins/core/ArgDefConditionChecker.java b/src/main/java/com/cflint/plugins/core/ArgDefConditionChecker.java index 8267a86e2..77463be72 100644 --- a/src/main/java/com/cflint/plugins/core/ArgDefConditionChecker.java +++ b/src/main/java/com/cflint/plugins/core/ArgDefConditionChecker.java @@ -46,7 +46,7 @@ public void element(final Element element, final Context context, final BugList } } - private boolean isCheck(String content, final String name) { + private boolean isCheck(final String content, final String name) { boolean checked = false; String stripped = content.replace(" ", "").replace("'", "\"").toLowerCase(); boolean structKeyCheck = (stripped.contains("structkeyexists(arguments,\"" + name + "\"")); diff --git a/src/main/java/com/cflint/plugins/core/ArgHintChecker.java b/src/main/java/com/cflint/plugins/core/ArgHintChecker.java index c9a33f2d9..496342300 100644 --- a/src/main/java/com/cflint/plugins/core/ArgHintChecker.java +++ b/src/main/java/com/cflint/plugins/core/ArgHintChecker.java @@ -33,7 +33,7 @@ public void element(final Element element, final Context context, final BugList } @Override - public void expression(CFScriptStatement expression, Context context, BugList bugs) { + public void expression(final CFScriptStatement expression, Context context, BugList bugs) { if (expression instanceof CFFuncDeclStatement) { final CFFuncDeclStatement funcDeclStatement = (CFFuncDeclStatement) expression; final String _mlText = PrecedingCommentReader.getMultiLine(context, expression.getToken()); diff --git a/src/main/java/com/cflint/plugins/core/ComponentHintChecker.java b/src/main/java/com/cflint/plugins/core/ComponentHintChecker.java index 10277df7e..437e91ed3 100644 --- a/src/main/java/com/cflint/plugins/core/ComponentHintChecker.java +++ b/src/main/java/com/cflint/plugins/core/ComponentHintChecker.java @@ -29,7 +29,7 @@ public void element(final Element element, final Context context, final BugList } @Override - public void expression(CFScriptStatement expression, Context context, BugList bugs) { + public void expression(final CFScriptStatement expression, Context context, BugList bugs) { if (expression instanceof CFCompDeclStatement) { final CFCompDeclStatement compDeclStatement = (CFCompDeclStatement) expression; final CFExpression hintAttribute = CFTool.convertMap(compDeclStatement.getAttributes()).get("hint"); diff --git a/src/main/java/com/cflint/plugins/core/FunctionHintChecker.java b/src/main/java/com/cflint/plugins/core/FunctionHintChecker.java index f7a7b8552..34ede10a9 100644 --- a/src/main/java/com/cflint/plugins/core/FunctionHintChecker.java +++ b/src/main/java/com/cflint/plugins/core/FunctionHintChecker.java @@ -29,7 +29,7 @@ public void element(final Element element, final Context context, final BugList } @Override - public void expression(CFScriptStatement expression, Context context, BugList bugs) { + public void expression(final CFScriptStatement expression, Context context, BugList bugs) { if (expression instanceof CFFuncDeclStatement) { final CFFuncDeclStatement funcDeclStatement = (CFFuncDeclStatement) expression; final CFExpression hintAttribute = CFTool.convertMap(funcDeclStatement.getAttributes()).get("hint"); diff --git a/src/main/java/com/cflint/plugins/core/LiteralChecker.java b/src/main/java/com/cflint/plugins/core/LiteralChecker.java index ccd3fb354..2191d8365 100644 --- a/src/main/java/com/cflint/plugins/core/LiteralChecker.java +++ b/src/main/java/com/cflint/plugins/core/LiteralChecker.java @@ -100,7 +100,7 @@ protected boolean isCommon(final String name) { * @param name * @return */ - private boolean isSpecial(String name) { + private boolean isSpecial(final String name) { //Empty literals do not flag if(name == null || name.length()==0){ return true; diff --git a/src/main/java/com/cflint/plugins/core/PackageCaseChecker.java b/src/main/java/com/cflint/plugins/core/PackageCaseChecker.java index 0675d08e7..3ac7b4250 100644 --- a/src/main/java/com/cflint/plugins/core/PackageCaseChecker.java +++ b/src/main/java/com/cflint/plugins/core/PackageCaseChecker.java @@ -65,7 +65,7 @@ private boolean checkComponentRegister(final Context context, final String compo } @Override - public void startComponent(Context context, BugList bugs) { + public void startComponent(final Context context, BugList bugs) { final String key = context.getComponentName().toLowerCase(); if(!componentRegister.containsKey(key)){ componentRegister.put(key, new ArrayList()); @@ -93,11 +93,11 @@ public void startComponent(Context context, BugList bugs) { } } - private String normalize(String filename) { + private String normalize(final String filename) { return filename.replaceAll(".[cC][fF][cC]$", "").replace("\\",".").replace("/","."); } - private boolean isCreateObject(CFFunctionExpression funcExpr) { + private boolean isCreateObject(final CFFunctionExpression funcExpr) { return "createobject".equalsIgnoreCase(funcExpr.getFunctionName()) && funcExpr.getArgs().size() > 1 && "'component'".equalsIgnoreCase(funcExpr.getArgs().get(0).Decompile(0)); } @@ -116,7 +116,7 @@ public PackageCaseCheckerEntry(Context context, String componentPath,final Strin } @Override - public void setCFLint(CFLint cflint) { + public void setCFLint(final CFLint cflint) { this.cflintRef = cflint; } } \ No newline at end of file diff --git a/src/main/java/com/cflint/plugins/core/SimpleComplexityChecker.java b/src/main/java/com/cflint/plugins/core/SimpleComplexityChecker.java index f1475dc77..a1f2be126 100644 --- a/src/main/java/com/cflint/plugins/core/SimpleComplexityChecker.java +++ b/src/main/java/com/cflint/plugins/core/SimpleComplexityChecker.java @@ -23,7 +23,7 @@ public class SimpleComplexityChecker extends CFLintScannerAdapter { private int functionLineNo = 1; @Override - public void startFile(String fileName, BugList bugs) { + public void startFile(final String fileName, BugList bugs) { complexity = 0; alreadyTooComplex = false; functionLineNo = 1; diff --git a/src/main/java/com/cflint/plugins/core/TooManyFunctionsChecker.java b/src/main/java/com/cflint/plugins/core/TooManyFunctionsChecker.java index dea4acdea..b23af28a9 100644 --- a/src/main/java/com/cflint/plugins/core/TooManyFunctionsChecker.java +++ b/src/main/java/com/cflint/plugins/core/TooManyFunctionsChecker.java @@ -56,7 +56,7 @@ protected void checkNumberFunctions(final int functionCount, final int atLine, f } } - public void startComponent(Context context, BugList bugs) { + public void startComponent(final Context context, BugList bugs) { functionCount = 0; } diff --git a/src/main/java/com/cflint/plugins/core/UnusedArgumentChecker.java b/src/main/java/com/cflint/plugins/core/UnusedArgumentChecker.java index 84bfc0ca2..9fbccf764 100644 --- a/src/main/java/com/cflint/plugins/core/UnusedArgumentChecker.java +++ b/src/main/java/com/cflint/plugins/core/UnusedArgumentChecker.java @@ -115,7 +115,7 @@ public void endFunction(final Context context, final BugList bugs) { } } - private boolean isUsed(String content, final String name) { + private boolean isUsed(final String content, final String name) { boolean isUsed = false; String stripped = content.replace(" ", "").replace("'", "\"").toLowerCase(); boolean structKeyCheck = (stripped.contains("arguments[\"" + name + "\"]")); diff --git a/src/main/java/com/cflint/plugins/core/UnusedLocalVarChecker.java b/src/main/java/com/cflint/plugins/core/UnusedLocalVarChecker.java index 81eb840d2..2b2586b90 100644 --- a/src/main/java/com/cflint/plugins/core/UnusedLocalVarChecker.java +++ b/src/main/java/com/cflint/plugins/core/UnusedLocalVarChecker.java @@ -98,9 +98,9 @@ public static class VarInfo { private Integer lineNumber; private String name; - public VarInfo(String name, Boolean used){ - this.name=name; - this.used=used; + public VarInfo(final String name, Boolean used) { + this.name = name; + this.used = used; } } @@ -122,7 +122,7 @@ public void element(final Element element, final Context context, final BugList } @Override - public void setParameter(String name, Object value) { + public void setParameter(final String name, Object value) { super.setParameter(name, value); if("UsedTagAttributes".equals(name)){ usedTagAttributes = getParameter("UsedTagAttributes",List.class); diff --git a/src/main/java/com/cflint/plugins/core/VariableNameChecker.java b/src/main/java/com/cflint/plugins/core/VariableNameChecker.java index 0207dba56..400747339 100644 --- a/src/main/java/com/cflint/plugins/core/VariableNameChecker.java +++ b/src/main/java/com/cflint/plugins/core/VariableNameChecker.java @@ -56,7 +56,7 @@ public void element(final Element element, final Context context, final BugList } @Override - public void setParameter(String name, Object value) { + public void setParameter(final String name, Object value) { super.setParameter(name, value); populateExclusions(); @@ -181,7 +181,7 @@ public void checkNameForBugs(final Context context, final String fullVariable, f } } - protected boolean excludeFromAnalyse(String variable) { + protected boolean excludeFromAnalyse(final String variable) { return exclusions.contains(normalize(variable)); } diff --git a/src/main/java/com/cflint/tools/CommentReformatting.java b/src/main/java/com/cflint/tools/CommentReformatting.java index bdfbf083a..969b0bb86 100644 --- a/src/main/java/com/cflint/tools/CommentReformatting.java +++ b/src/main/java/com/cflint/tools/CommentReformatting.java @@ -7,7 +7,7 @@ public class CommentReformatting { private static final String COMMENT_TEXT = ""; - public static String wrap(String value) { + public static String wrap(final String value) { Stack stack = new Stack<>(); StringBuilder sb = new StringBuilder(value); int pos = sb.indexOf(COMMENT_TEXT); diff --git a/src/main/java/com/cflint/tools/ObjectEquals.java b/src/main/java/com/cflint/tools/ObjectEquals.java index db5a41c1f..285230684 100644 --- a/src/main/java/com/cflint/tools/ObjectEquals.java +++ b/src/main/java/com/cflint/tools/ObjectEquals.java @@ -2,7 +2,7 @@ public class ObjectEquals { - public static boolean equals(Object a, Object b) { + public static boolean equals(final Object a, final Object b) { if (a == null) { return b == null; } else { diff --git a/src/main/java/com/cflint/tools/PrecedingCommentReader.java b/src/main/java/com/cflint/tools/PrecedingCommentReader.java index deb536162..2cc3676f5 100644 --- a/src/main/java/com/cflint/tools/PrecedingCommentReader.java +++ b/src/main/java/com/cflint/tools/PrecedingCommentReader.java @@ -11,7 +11,7 @@ public class PrecedingCommentReader { public static final String CFC_DEFAULT_EXTENSION = ".cfc"; public static final String CFM_DEFAULT_EXTENSION = ".cfm"; - public static String getMultiLine(Context context, final Token token) { + public static String getMultiLine(final Context context, final Token token) { Iterable tokens = context.beforeTokens(token); for (Token currentTok : tokens) { if (currentTok.getChannel() == Token.HIDDEN_CHANNEL && currentTok.getType() == CFSCRIPTLexer.ML_COMMENT) { diff --git a/src/main/java/com/cflint/xml/MarshallerException.java b/src/main/java/com/cflint/xml/MarshallerException.java index f692cf389..2dc87b2aa 100644 --- a/src/main/java/com/cflint/xml/MarshallerException.java +++ b/src/main/java/com/cflint/xml/MarshallerException.java @@ -10,15 +10,15 @@ public class MarshallerException extends Exception { public MarshallerException() { } - public MarshallerException(String message) { + public MarshallerException(final String message) { super(message); } - public MarshallerException(String message, Throwable cause) { + public MarshallerException(final String message, Throwable cause) { super(message, cause); } - public MarshallerException(Throwable cause) { + public MarshallerException(final Throwable cause) { super(cause); } } diff --git a/src/main/java/com/cflint/xml/stax/DefaultCFlintResultMarshaller.java b/src/main/java/com/cflint/xml/stax/DefaultCFlintResultMarshaller.java index 6b6c28d90..49221dbe7 100644 --- a/src/main/java/com/cflint/xml/stax/DefaultCFlintResultMarshaller.java +++ b/src/main/java/com/cflint/xml/stax/DefaultCFlintResultMarshaller.java @@ -19,7 +19,7 @@ public class DefaultCFlintResultMarshaller implements CFLintResultMarshaller { @Override - public void output(BugList bugList, Writer writer, CFLintStats stats) throws MarshallerException { + public void output(final BugList bugList, Writer writer, CFLintStats stats) throws MarshallerException { try { final XMLOutputFactory xmlOutputFactory = XMLOutputFactory.newInstance(); @@ -34,7 +34,7 @@ public void output(BugList bugList, Writer writer, CFLintStats stats) throws Mar } } - private void writeIssues(BugList bugList, XMLStreamWriter xtw, CFLintStats stats) throws XMLStreamException { + private void writeIssues(final BugList bugList, XMLStreamWriter xtw, CFLintStats stats) throws XMLStreamException { xtw.writeStartElement("issues"); xtw.writeAttribute("version", Version.getVersion()); xtw.writeAttribute("timestamp", Long.toString(stats.getTimestamp())); @@ -50,7 +50,7 @@ private void writeIssues(BugList bugList, XMLStreamWriter xtw, CFLintStats stats xtw.writeEndElement(); } - private void writeCounts(XMLStreamWriter xtw, BugCounts counts, CFLintStats stats) throws XMLStreamException { + private void writeCounts(final XMLStreamWriter xtw, BugCounts counts, CFLintStats stats) throws XMLStreamException { xtw.writeStartElement("counts"); xtw.writeAttribute("totalfiles", Long.toString(stats.getFileCount())); xtw.writeAttribute("totallines", stats.getTotalLines().toString()); @@ -74,7 +74,7 @@ private void writeCounts(XMLStreamWriter xtw, BugCounts counts, CFLintStats stat xtw.writeEndElement(); } - private void writeIssue(XMLStreamWriter xtw, BugInfo bug) throws XMLStreamException { + private void writeIssue(final XMLStreamWriter xtw, BugInfo bug) throws XMLStreamException { xtw.writeStartElement("issue"); xtw.writeAttribute("severity", valueOf(bug.getSeverity().toString())); @@ -88,7 +88,7 @@ private void writeIssue(XMLStreamWriter xtw, BugInfo bug) throws XMLStreamExcept xtw.writeEndElement(); } - private void writeLocation(XMLStreamWriter xtw, BugInfo bug) throws XMLStreamException { + private void writeLocation(final XMLStreamWriter xtw, BugInfo bug) throws XMLStreamException { xtw.writeStartElement("location"); xtw.writeAttribute("file", valueOf(bug.getFilename())); xtw.writeAttribute("fileName", valueOf(new File(bug.getFilename()).getName())); @@ -103,7 +103,7 @@ private void writeLocation(XMLStreamWriter xtw, BugInfo bug) throws XMLStreamExc xtw.writeEndElement(); } - private void writeExpression(XMLStreamWriter xtw, BugInfo bug) throws XMLStreamException { + private void writeExpression(final XMLStreamWriter xtw, BugInfo bug) throws XMLStreamException { xtw.writeStartElement("Expression"); escapeDeep(xtw, valueOf(bug.getExpression())); @@ -124,7 +124,7 @@ private void escapeDeep(XMLStreamWriter xtw, String data) throws XMLStreamExcept } } - private String escapeControlCharacters(String value) { + private String escapeControlCharacters(final String value) { StringBuilder sb = new StringBuilder(value); for (int i = 0; i < sb.length(); i++) { @@ -153,11 +153,11 @@ private String abbrev(final String messageCode) { } } - private String valueOf(int value) { + private String valueOf(final int value) { return valueOf(String.valueOf(value)); } - private String valueOf(String value) { + private String valueOf(final String value) { if (value == null) { return ""; } @@ -168,13 +168,13 @@ private static class UnicodeCharEncoder { private static final char[] DIGITS = { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F' }; - public static String encode(int c) { + public static String encode(final int c) { return "&#x" + toHex(((c >> 12) & 0xF)) + toHex(((c >> 8) & 0xF)) + toHex(((c >> 4) & 0xF)) + toHex(c & 0xF) + ";"; } - public static char toHex(int val) { + public static char toHex(final int val) { return DIGITS[val & 0xF]; }