Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chai 1.9.2 does not work well with sinon-chai 2.5.0 #295

Closed
mck- opened this issue Oct 1, 2014 · 5 comments
Closed

Chai 1.9.2 does not work well with sinon-chai 2.5.0 #295

mck- opened this issue Oct 1, 2014 · 5 comments

Comments

@mck-
Copy link

mck- commented Oct 1, 2014

TypeError: 'undefined' is not a function whenever calledWith is used.

Worked with 1.9.1

@logicalparadox
Copy link
Member

First thought is this is related to #268, but I am not familiar enough with the internals of sinon-chai.

@charlierudolph @domenic Can you confirm, and is this a Chai problem or a sinon-chai problem?

@domenic
Copy link
Contributor

domenic commented Oct 2, 2014

Can try to look into it. Excited that #268 is there now though so we can use that in Sinon-Chai. (Even if it is currently breaking things, I still want it :)

@domenic
Copy link
Contributor

domenic commented Oct 5, 2014

@mck- I cannot reproduce locally; can you create a test repo showing the problem?

@domenic
Copy link
Contributor

domenic commented Oct 5, 2014

In any case, Sinon–Chai 2.6.0 now takes advantage of lazy messages :D

@keithamus
Copy link
Member

@mck- I'm going to close this one. Thanks for your time in filing this, and if it you see it again, please just reply back and we'll re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants