Updated classifyBySide to only classify as front or back if polygon i…

…s wholly in front of or behind.
chandlerprall · Aug 3, 2018 · 6040bc2 · 6040bc2
1 parent 22d8bbc
commit 6040bc2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/ThreeCSG.js b/ThreeCSG.js
@@ -288,15 +288,15 @@ window.ThreeBSP = (function() {
 			}
 		}
 
-		if ( num_positive > 0 && num_negative === 0 ) {
-			return FRONT;
-		} else if ( num_positive === 0 && num_negative > 0 ) {
-			return BACK;
-		} else if ( num_positive === 0 && num_negative === 0 ) {
-			return COPLANAR;
-		} else {
-			return SPANNING;
-		}
+        if ( num_positive === vertice_count && num_negative === 0 ) {
+            return FRONT;
+        } else if ( num_positive === 0 && num_negative === vertice_count ) {
+            return BACK;
+        } else if ( num_positive > 0 && num_negative > 0 ) {
+            return SPANNING;
+        } else {
+            return COPLANAR;
+        }
 	};
 	ThreeBSP.Polygon.prototype.splitPolygon = function( polygon, coplanar_front, coplanar_back, front, back ) {
 		var classification = this.classifySide( polygon );

diff --git a/threeCSG.es6 b/threeCSG.es6
@@ -299,14 +299,14 @@ class Polygon {
             }
         }
 
-        if (num_positive > 0 && num_negative === 0) {
+        if (num_positive === vertice_count && num_negative === 0) {
             return FRONT;
-        } else if (num_positive === 0 && num_negative > 0) {
+        } else if (num_positive === 0 && num_negative === vertice_count) {
             return BACK;
-        } else if (num_positive === 0 && num_negative === 0) {
-            return COPLANAR;
-        } else {
+        } else if (num_positive > 0 && num_negative > 0) {
             return SPANNING;
+        } else {
+            return COPLANAR;
         }
     }