Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update directories and file names to be more meaningful #315

Open
alpgarcia opened this issue Dec 13, 2018 · 2 comments
Open

Update directories and file names to be more meaningful #315

alpgarcia opened this issue Dec 13, 2018 · 2 comments

Comments

@alpgarcia
Copy link
Contributor

First of all, is it a repository of one collection of panels, or several collections? It seems it's growing to several panels collections, isn't it?:

  • json (current GrimoireLab standard panels). These are the ones installed also through PyPi packages (see panels directory used in the package)
  • dashboards-cauldron. The legacy panels used in Cauldron.io. They should be deprecated at some point
  • chaoss-gmd-cde. The upcoming CHAOSS GMD Code Development focus area panels

There are also code and tools related with panels management, that are stored here too:

  • import_panels.sh
  • src directory

So, my proposal would be:

  • provide meaningful names to the .json panels files directories. I would recommend to avoid acronyms. So they could become:
    • rename json folder to sigils: standard set of GrimoireLab panels. It would be needed to rewrite the symbolic link in panels directory (or improve the way the package manages the panels collections), and maybe it could have some undesired effects in current Bitergia deployment infra (but that's Bitergia issue, not GrimoireLab Sigils issue).
    • rename dashboards-cauldron to cauldron: set of panels used in Cauldron.io
    • rename chaoss-gmd-cde to chaoss-gmd-wg-code-development
  • move the tools and scrips to a utils directory, with its own README.md or set of .md files for documentation
  • use docs folder for GrimoireLab Sigils and its collections documentation. This mean, that there could be several docs or pages in that folder, and a set of collections with the same names that the ones used in the root directory for the directories of .json files.
@alpgarcia
Copy link
Contributor Author

Two comments:

  • rename chaoss-gmd-cde to chaoss-gmd-wg-code-development

I renamed it the other way around because @dicortazar thought it was too long : P

for each <collection_name>/<panel_file_name>.json there must be a docs/_<collection_name>/<panel_file_name>.md and docs/assets/images/<collection_name>/<panel_file_name>.jpg

After reading this I think you are the right person to review #304. @sduenas do you know if this check could be hooked somewhere?

If anyone complains, I would suggest to create a PR with these modifications.

@jsmanrique
Copy link
Contributor

Two comments:

  • rename chaoss-gmd-cde to chaoss-gmd-wg-code-development

I renamed it the other way around because @dicortazar thought it was too long : P

For me, the cde part was a bit tricky. It could be: chaoss-gmd-wg-code-dev

for each <collection_name>/<panel_file_name>.json there must be a docs/_<collection_name>/<panel_file_name>.md and docs/assets/images/<collection_name>/<panel_file_name>.jpg

After reading this I think you are the right person to review #304. @sduenas do you know if this check could be hooked somewhere?

If anyone complains, I would suggest to create a PR with these modifications.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants