Subtasks for macro-benchmarking: count() update
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmoniumQ
reviewed
Aug 15, 2024
benchmark/prov_collectors.py
Outdated
Comment on lines
58
to
63
| ProvOperation( | ||
| type=op.type, | ||
| target0=op.target0, | ||
| target1=op.target1, | ||
| args=op.args | ||
| ) |
There was a problem hiding this comment.
We will switch on the type of op.data. All of our ops so far have zero or one targets, the args can be left blank.
saleha-muzammil
changed the title
count() update
|
So were you able to test this code? |
charmoniumQ
reviewed
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Change provenance_collectors.py -> PROBE to have a count() function. count() should transcribe and dump the provenance log. It should import
probe_py.generated.parser. We should convert the Ops to ProvOperation, and return a tuple of them from count().@charmoniumQ please lmk if i am on the right track or not since was unsure. I had a confusion regarding doing
transcribein thecount()as I think that it would requirePROBE_DIRas well ?