Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix startOf function for isoWeek #22

Closed
stockiNail opened this issue Aug 10, 2020 · 1 comment
Closed

Fix startOf function for isoWeek #22

stockiNail opened this issue Aug 10, 2020 · 1 comment

Comments

@stockiNail
Copy link

The startOf function is accepting a boolean for Sunday(false) and Monday(true).

Instead it should get the the week day (number) between 0 (Sunday) and 6(Saturday) in order to be more flexible to provide the startOf the week based on the parameter.

See chartjs/chartjs-adapter-luxon#23
@stockiNail stockiNail mentioned this issue Aug 10, 2020
Closed
@kurkle
Copy link
Member

kurkle commented Sep 7, 2020

It already works as expected.

@kurkle kurkle closed this as completed Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

startOf function is accepting number as weekday from 0(Sun) to 6(Sat)
2 participants
@stockiNail @kurkle