Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability report #10

Open
JafarAkhondali opened this issue Jun 5, 2024 · 7 comments · May be fixed by #11
Open

Vulnerability report #10

JafarAkhondali opened this issue Jun 5, 2024 · 7 comments · May be fixed by #11

Comments

@JafarAkhondali
Copy link

We are a group of researchers from Leiden University, and we conduct research on vulnerabilities in open-source software. We have discovered and verified a high-severity vulnerability in your project(chcunningham/wc-talk). Explaining the vulnerability further in this issue could allow malicious users to access details, so we recommend enabling private vulnerability reporting on GitHub to discuss this matter confidentially.
After you have enabled this feature, please add a comment to this issue so we can continue our discussion. If you have any questions, feel free to leave a reply here or send an email to: j.akhoundali [at] liacs.leidenuniv.nl

@guest271314
Copy link

Wouldn't it make sense to publicly disclose the common vulnerabilities and exposures so we all can examine the issue?

@JafarAkhondali
Copy link
Author

@guest271314 No, vulnerability reports should be discussed privately until maintainers provide a fix. Also if there is no response from the maintainers (in ~1month), then the vulnerability can be public so that users are aware of the issue.

@guest271314
Copy link

Interesting philosophy. I would just expose the exploit so users in the field can be aware that they are running software vulnerable to exploits and maintainers can also know they are producing code with vulnerabilities. Full disclosure all the way around. No secrets.

@JafarAkhondali
Copy link
Author

We follow best practices from other source: https://cheatsheetseries.owasp.org/cheatsheets/Vulnerability_Disclosure_Cheat_Sheet.html
So If they don't respond in time, we will make the vulnerability details public(similar to Google's Project Zero).

@guest271314
Copy link

Right, the 2d option is full disclosure. It is possible that users and/or developers in the field can come up with a fix that maintainers have not thought about. Anyway, I'll check out what's going on here when the details are made public.

@JafarAkhondali JafarAkhondali linked a pull request Jul 30, 2024 that will close this issue
@JafarAkhondali
Copy link
Author

@guest271314 Now you can check the details :)

@guest271314
Copy link

Reproducible with node v23.0.0-nightly202407272d1b4a8cf7 on Linux.

$ curl --path-as-is 0.0.0.0:8888/../../../../../../../../../../../../../../../../../../../etc/hostname
user

I converted the script to use Ecmascript Modules instead of CommonJS.

This also fixes the issue

  var filename = `./${new URL(request.url, import.meta.url).pathname}`;

by using the base parameter to URL() constructor https://developer.mozilla.org/en-US/docs/Web/API/URL/URL, import.meta.url, and prefixing the filename variable with ./

Static file server running at
  => http://localhost:8888/index.html
CTRL + C to shutdown
.//etc/hostname
File doesn't exist:.//etc/hostname
$ curl --path-as-is 0.0.0.0:8888/../../../../../../../../../../../../../../../../../../../etc/hostname
404 Not Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants