image_id should be a bootstrap_options instead of machine_option?

[miguelcnf]

As far as I can see, the image_id should be a bootstrap_option instead of a machine_option as described here.

This is also to be coherent with the fog:AWS driver.

[esciara]

Even though the link you provide most likely refers to the fog:AWS driver only (does not look like there is a doc to this AWS driver at all), IMHO I would say that indeed, the image_id should be in bootstrap_options. I could not set my image_id at all (if you have a work around, I am all ears), and the driver defaulted automatically to an ebs type image, which I cannot use with the instance_type t2.micro I want to use in a vpc'ed environment.

In essence, this should work:

with_data_center 'eu-west-1' do
  machine "esc_poc_aws_driver" do
    machine_options :bootstrap_options => {
      :key_name => 'chefserver', 
      :image_id => 'ami-60a10117', # ubuntu/images/hvm/ubuntu-precise-12.04-amd64-server-20140927
      :instance_type => 't2.micro',
      :subnet => 'subnet-0a935c6f'
    }
  end
end

But does not:

[..]
[2014-12-26T02:03:15+01:00] DEBUG: Choosing default AMI for region 'eu-west-1'
[2014-12-26T02:03:15+01:00] DEBUG: AWS Bootstrap options: {:key_name=>"chefserver", :image_id=>"ami-4ab46b3d", :instance_type=>"t2.micro", :subnet=>"subnet-0a935c6f"}
[2014-12-26T02:03:15+01:00] DEBUG: Creating instance with bootstrap options {:key_name=>"chefserver", :image_id=>"ami-4ab46b3d", :instance_type=>"t2.micro", :subnet=>"subnet-0a935c6f"}


    ================================================================================
    Error executing action `converge` on resource 'machine[esc_poc_aws_driver]'
    ================================================================================

    AWS::EC2::Errors::InvalidParameterCombination
    ---------------------------------------------
    Virtualization type 'hvm' is required for instances of type 't2.micro'.
[..]

As you can see here, :image_id => 'ami-60a10117' has been superseded by the region's default :image_id=>"ami-4ab46b3d" and always will due to this bug.

As for the bootstrap_options, they are quite different to those of the fog::AWS driver. I will open another issue on that front.

Really looking forward to have your PR merged!

[esciara]

For info, workaround for this:

with_data_center 'eu-west-1' do
  machine "esc_poc_aws_driver" do
    options = {:bootstrap_options => {
      :key_name => 'chefserver', 
      :instance_type => 't2.micro',
      :subnet => 'subnet-0a935c6f'
    },
     :image_id => 'ami-60a10117'}
    machine_options options
  end
end

[miguelcnf]

That's pretty much the workaround I've used until now - setting the image_id it as a machine option instead of bootstrap.

I had that exact same problem as I wanted to spin up instances inside a vpc.

[jkeiser]

#89 checked in to fix this.