Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung Selinux Status removed even when enforcing #475

Open
Fede2782 opened this issue Nov 11, 2024 · 6 comments
Open

Samsung Selinux Status removed even when enforcing #475

Fede2782 opened this issue Nov 11, 2024 · 6 comments

Comments

@Fede2782
Copy link

In Samsung devices with Selinux enforcing this build prop must be set to 1 in order to have settings and other apps show the correct selinux status.

@salvogiangri already did a patch to fix this. If the value is already set to 1 there is not need to do anything.

@essence25
Copy link

essence25 commented Dec 8, 2024

Im experiencing this now with PlayIntegrityFix v18.0, TB Checker "SE linux Flag is Enabled = Fail" where it always passed.
Also in DevInfo "SELinux = Unable to Determine" app has root permission.
Kernel SU shows enforced and command line "getenforce" shows Enforced.

How can I fix this? (Galaxy TAB S9+)

@DanGLES3
Copy link
Contributor

DanGLES3 commented Dec 8, 2024

Im experiencing this now with PlayIntegrityFix v18.0, TB Checker "SE linux Flag is Enabled = Fail" where it always passed. Also in DevInfo "SELinux = Unable to Determine" app has root permission. Kernel SU shows enforced and command line "getenforce" shows Enforced.

How can I fix this? (Galaxy TAB S9+)

That check is a false positive, The property it is looking for is present even on stock unrooted Samsung ROMs

TB Checker will say fail even when ro.build.selinux is set to 1 (which it shouldn't as 1 means enforcing), no actual app falls for this false positive

In short, TB Checker Selinux flag check is broken

@DanGLES3
Copy link
Contributor

DanGLES3 commented Dec 8, 2024

Im experiencing this now with PlayIntegrityFix v18.0, TB Checker "SE linux Flag is Enabled = Fail" where it always passed. Also in DevInfo "SELinux = Unable to Determine" app has root permission. Kernel SU shows enforced and command line "getenforce" shows Enforced.

How can I fix this? (Galaxy TAB S9+)

As for why it started failing when updating to 18.0, previous versions used to delete that property needlessly (even when it was set to 1) just to appease broken detection apps

You can safely ignore that check failing as it's a completely bogus and broken check

@essence25
Copy link

Yes, you are correct. I just went back to v17.9 to test and TB Checker will pass again all root tests. Hmm... So the detection apps need to be updated in that case. Thank you for clarifying.

@DanGLES3
Copy link
Contributor

DanGLES3 commented Dec 8, 2024

Yes, you are correct. I just went back to v17.9 to test and TB Checker will pass again all root tests. Hmm... So the detection apps need to be updated in that case. Thank you for clarifying.

The only checkers that have this broken check are those based off of rootbeer which is a very outdated checking library that very few real apps use and even when they do they ignore the broken selinux check

@essence25
Copy link

essence25 commented Dec 8, 2024

Funny thing is RootBeerFresh passes with "NOT ROOTED" on v18.0 of PiF but fails on v17.9 (SE linux Flag), so sticking with v18.0.
All good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants