New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal.end does not kill the process #188

Open

nosemeocurrenada opened this issue Aug 11, 2017 · 0 comments

nosemeocurrenada commented Aug 11, 2017

The function in

pty.js/lib/pty.js

Lines 270 to 272 in fe63a41

    
           Terminal.prototype.end = function(data) { 
        
             return this.socket.end(data); 
        
           };

calls net.Socket.end(), which does not kill the socket, as stated in https://nodejs.org/api/net.html#net_socket_end_data_encoding.
Is this behavior intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment