Chocolatey fails to install in PowerShell v2 with PowerShell Module 1.x #128

gruffled · 2016-06-07T12:29:44Z

Powershell plug in is 1.06
Chocolatey plug in is 1.2.4
Chocolatey package is 0.9.10-beta-2016032

The main choco install is failing as below. we are using the beta 9.10 package installed from a private repo.

        my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: ï»¿
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: Mode                LastWriteTime     Length Name                              
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: ----                -------------     ------ ----                              
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: d----        07/06/2016     13:13            chocInstall                       
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: 
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: 
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: Downloading http://myserver/NuGet/api/v2/package/chocolatey/0.9.10-beta-2016032
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: 3 to C:\Users\puppet\AppData\Local\Temp\chocolatey\chocInstall\chocolatey.zip
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: Installing chocolatey on this machine
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: The term 'else' is not recognized as the name of a cmdlet, function, script fil
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: e, or operable program. Check the spelling of the name, or if a path was includ
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: ed, verify that the path is correct and try again.
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: At line:1 char:5
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: + else <<<<  {
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns:     + CategoryInfo          : ObjectNotFound: (else:String) [], ParentContains 
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns:    ErrorRecordException
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns:     + FullyQualifiedErrorId : CommandNotFoundException
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns:  
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: Ensuring chocolatey commands are on the path
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: Ensuring chocolatey.nupkg is in the lib folder
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: 
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: Mode                LastWriteTime     Length Name                              
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: ----                -------------     ------ ----                              
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: d----        07/06/2016     13:14            chocolatey                        
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: executed successfully
    my_machine: Debug: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]: The container Class[Chocolatey::Install] will propagate my refresh event
    my_machine: Debug: Exec[install_chocolatey_official](provider=powershell): Executing 'cmd.exe /c ""C:\Windows\system32\WindowsPowershell\v1.0\powershell.exe" -NoProfile -NonInteractive -NoLogo -ExecutionPolicy Bypass -Command - < "C:\Users\puppet\AppData\Local\Temp\puppet-powershell20160607-668-12s53an.ps1""'
    my_machine: Debug: Executing 'cmd.exe /c ""C:\Windows\system32\WindowsPowershell\v1.0\powershell.exe" -NoProfile -NonInteractive -NoLogo -ExecutionPolicy Bypass -Command - < "C:\Users\puppet\AppData\Local\Temp\puppet-powershell20160607-668-12s53an.ps1""'
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: ï»¿Downloading http://myserver/NuGet/api/v2/package/chocolatey/0.9.10-beta-2016032
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: 3 to C:\Users\puppet\AppData\Local\Temp\chocolatey\chocInstall\chocolatey.zip
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: Installing chocolatey on this machine
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: The term 'else' is not recognized as the name of a cmdlet, function, script fil
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: e, or operable program. Check the spelling of the name, or if a path was includ
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: ed, verify that the path is correct and try again.
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: At line:1 char:5
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: + else <<<<  {
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns:     + CategoryInfo          : ObjectNotFound: (else:String) [], ParentContains 
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns:    ErrorRecordException
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns:     + FullyQualifiedErrorId : CommandNotFoundException
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns:  
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: Ensuring chocolatey commands are on the path
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]/returns: Ensuring chocolatey.nupkg is in the lib folder
    my_machine: Notice: /Stage[setup]/Chocolatey::Install/Exec[install_chocolatey_official]: Triggered 'refresh' from 2 events

The text was updated successfully, but these errors were encountered:

gruffled · 2016-06-07T12:32:18Z

Should note this only started since the chocolatey module went from 1.2.3 to 1.2.4

ferventcoder · 2016-06-07T12:43:25Z

And Puppet version is? :)

ferventcoder · 2016-06-07T12:43:58Z

The only place in the code that looks like this is : https://github.com/chocolatey/puppet-chocolatey/blob/461a0aa0ffca2fb4431c559ad1468d23a0687061/templates/InstallChocolatey.ps1.erb#L105

ferventcoder · 2016-06-07T12:44:27Z

side note: I also recommend upgrading your beta.

ferventcoder · 2016-06-07T12:51:00Z

It seems the try/catch is likely causing this error later. Perhaps if you can help me adjust that - we can try to determine what is causing it - I tested this scenario with the older PowerShell provider on Windows 2008 R2 and didn't see this issue, so I missed getting this to happen.

ferventcoder · 2016-06-07T12:52:07Z

Let's try changing that line to } else { (the } is on the line above it, so just remove the line break).

gruffled · 2016-06-07T13:18:07Z

Puppet version is 3.8.4

I've made the change, running a build now to see what happens.

gruffled · 2016-06-07T13:40:56Z

That seems to have done the trick :)

ferventcoder · 2016-06-07T13:42:17Z

ugh, fun times - let's fix that.

ferventcoder · 2016-06-07T13:43:19Z

Do you want to follow up with a pull request or do you just want me to fix it?

…allation issues with older versuions of the powershell module.

Removed a line break which was causing installation issues with 1.x versions of the PowerShell provider module. Older versions of PowerShell, such as PowerShell v2, and the 1.x module do not handle line breaks with else statements very well.

* pr129: (GH-128) PowerShell 1.x provider fixes for "else"

* master: (version) 1.2.5 (maint) prep for release of 1.2.5 (chocolatey-archiveGH-128) PowerShell 1.x provider fixes for "else" (chocolatey-archiveGH-133) Feature list update for 0.9.10 (version) 1.2.4 (chocolatey-archiveGH-125) Compatible Up to PowerShell Provider 3.x (chocolatey-archiveGH-125) Wrap PowerShell Redirect in Try/Catch (chocolatey-archiveGH-69) Fix - default provider example (doc) make that text a bit more prominent (version) 1.2.3 for real (version) 1.2.3 (doc) add editions of Chocolatey (chocolatey-archiveGH-100) Do not call choco with --debug --verbose (version) 1.2.2 Sign the installer script template (chocolatey-archiveGH-119) Implement PowerShell Redirection Fix

* master: (version) 1.2.6 (MODULES-3536) modsync update (maint) Remove travis and metadata-json-lint gems (chocolatey-archiveGH-134) Only Enable AutoUninstaller in 0.9.9.x (version) 1.2.5 (maint) prep for release of 1.2.5 (chocolatey-archiveGH-128) PowerShell 1.x provider fixes for "else" (chocolatey-archiveGH-133) Feature list update for 0.9.10 (version) 1.2.4 (chocolatey-archiveGH-125) Compatible Up to PowerShell Provider 3.x (chocolatey-archiveGH-125) Wrap PowerShell Redirect in Try/Catch (chocolatey-archiveGH-69) Fix - default provider example (doc) make that text a bit more prominent (version) 1.2.3 for real (version) 1.2.3 (doc) add editions of Chocolatey (chocolatey-archiveGH-100) Do not call choco with --debug --verbose (version) 1.2.2 Sign the installer script template (chocolatey-archiveGH-119) Implement PowerShell Redirection Fix

ferventcoder added Bug 0 - Backlog Priority_HIGH labels Jun 7, 2016

ferventcoder self-assigned this Jun 7, 2016

ferventcoder added this to the 1.2.5 milestone Jun 7, 2016

gruffled pushed a commit to gruffled/puppet-chocolatey that referenced this issue Jun 7, 2016

fixes issue chocolatey-archive#128

fc11039

gruffled pushed a commit to gruffled/puppet-chocolatey that referenced this issue Jun 7, 2016

fixes issue chocolatey-archive#128

d837407

gruffled pushed a commit to gruffled/puppet-chocolatey that referenced this issue Jun 7, 2016

fixes issue chocolatey-archive#128

b400b9f

gruffled pushed a commit to gruffled/puppet-chocolatey that referenced this issue Jun 7, 2016

(chocolatey-archive#128) Removed a line break whcih was causeing inst…

38a88ae

…allation issues with older versuions of the powershell module.

ferventcoder added a commit that referenced this issue Jun 20, 2016

Merge branch 'pr129'

7af3253

* pr129: (GH-128) PowerShell 1.x provider fixes for "else"

ferventcoder added the 3 - Done label Jun 20, 2016

gruffled mentioned this issue Jun 20, 2016

(GH-128) PowerShell provider 1.x gets confused with "else" statements with line breaks #129

Closed

ferventcoder changed the title ~~Chocolatey fails to install on Windows 2008r2~~ Chocolatey fails to install in PowerShell v2 with PowerShell Module 1.x Jun 20, 2016

ferventcoder closed this as completed Jun 20, 2016

ferventcoder removed the 0 - Backlog label Jun 20, 2016

gep13 unassigned ferventcoder Apr 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chocolatey fails to install in PowerShell v2 with PowerShell Module 1.x #128

Chocolatey fails to install in PowerShell v2 with PowerShell Module 1.x #128

gruffled commented Jun 7, 2016

gruffled commented Jun 7, 2016

ferventcoder commented Jun 7, 2016 •

edited

Loading

ferventcoder commented Jun 7, 2016

ferventcoder commented Jun 7, 2016 •

edited

Loading

ferventcoder commented Jun 7, 2016

ferventcoder commented Jun 7, 2016 •

edited

Loading

gruffled commented Jun 7, 2016

gruffled commented Jun 7, 2016

ferventcoder commented Jun 7, 2016

ferventcoder commented Jun 7, 2016

Chocolatey fails to install in PowerShell v2 with PowerShell Module 1.x #128

Chocolatey fails to install in PowerShell v2 with PowerShell Module 1.x #128

Comments

gruffled commented Jun 7, 2016

gruffled commented Jun 7, 2016

ferventcoder commented Jun 7, 2016 • edited Loading

ferventcoder commented Jun 7, 2016

ferventcoder commented Jun 7, 2016 • edited Loading

ferventcoder commented Jun 7, 2016

ferventcoder commented Jun 7, 2016 • edited Loading

gruffled commented Jun 7, 2016

gruffled commented Jun 7, 2016

ferventcoder commented Jun 7, 2016

ferventcoder commented Jun 7, 2016

ferventcoder commented Jun 7, 2016 •

edited

Loading

ferventcoder commented Jun 7, 2016 •

edited

Loading

ferventcoder commented Jun 7, 2016 •

edited

Loading