Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for choco existence more comprehensively #66

Closed
3 tasks done
ferventcoder opened this issue Jul 1, 2015 · 1 comment
Closed
3 tasks done

Check for choco existence more comprehensively #66

ferventcoder opened this issue Jul 1, 2015 · 1 comment
Assignees
@ferventcoder
Labels
3 - Done Enhancement
Milestone
1.0.1

Comments

@ferventcoder
Copy link
Contributor

When determining the location of choco.exe, look more for the choco.exe to exist versus just directories (as the directories may not get cleaned up).

  • The order is wrong and we should look for c:\programdata\chocolatey before the c:\chocolatey - there was an original reason for that order, but I don't remember if it is still valid or not.
  • Fall back to ChocolateyInstall Environment variable if the default path is not found
  • We can probably instead look for file existence instead of just the folder for a more comprehensive check

https://groups.google.com/d/msgid/chocolatey/a4b3c213-3a30-4932-b25a-56beed21376a%40googlegroups.com
ferventcoder added a commit that referenced this issue Jul 1, 2015
@ferventcoder
(GH-66) Comprehensive check choco.exe location
7caf9a5 
The current check only looks for the existence of directories with
fallback to a default location if it doesn't find any. The first check
against the environment variable may be incorrect if an old environment
variable is still lingering and can cause issues in finding the proper
provider location.

Check in a very explicit order for the existence of the choco.exe binary,
starting with default install, then the environment variable, then the old
default location, followed by the last check in the AllUsersProfile location
if nothing else can be found.
@ferventcoder
Copy link
Contributor Author

Released in v 1.0.1

@ferventcoder ferventcoder added this to the 1.0.1 milestone Jul 7, 2015
@ferventcoder ferventcoder self-assigned this Jul 7, 2015
DavidS pushed a commit to DavidS/puppetlabs-chocolatey that referenced this issue Mar 24, 2017
@eputnam
Merge pull request chocolatey-archive#66 from glennsarti/revert-fe09e…
fd5b0fa 
…cd998fb

Revert "MODULES-3302 add Rototiller to Rakefile"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
3 - Done Enhancement
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
1 participant
@ferventcoder