Avoiding puppet returning 2 instead of 0 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -178,7 +178,7 @@ def self.instances | |||
| else | |||
| values = line.split(' ') | |||
| end | |||
| packages << new({ :name => values[0], :ensure => values[1], :provider => self.name }) | |||
| packages << new({ :name => values[0].downcase, :ensure => values[1], :provider => self.name }) | |||
There was a problem hiding this comment.
Oh, I`m sorry!
I was using version 0.5.0, trying to install nssm with this module:
class nssm (
$version = latest,
$source = 'SEE NOTES',
) inherits nssm::params {
package{'nssm':
ensure => $version,
source => $source,
}
}
where the source was a miror of nuget central. The package is called "NSSM" and puppet returned 2 again and again. After this change it started to work.
I already know it is being done in the caller, but I do not know if this method is overriding an API method that can be called in other place.
Sadly, I cannot reproduce it right now; my whole environment is failing right now with other problem.
There was a problem hiding this comment.
You want to be on at least 0.5.1 - 0.5.0 has issues on Linux masters.
ferventcoder
added a commit
that referenced
this pull request
Apr 20, 2015
Avoiding puppet returning 2 instead of 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change avoids puppet to treturn 2 instead of 0 when there are no changes to be done.