-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI on more architectures and more operating systems #163
Run CI on more architectures and more operating systems #163
Conversation
@chriselrod Of the following, are there any OS+arch combinations that LoopVectorization does NOT support? If so, let me know and I'll remove them from the CI matrix.
|
I supported all of them before 0.9, but with all the VectorizationBase changes, I'll probably have to do some bug fixing. It'd be good to be able to test on ARM as well. |
Unfortunately, GitHub Actions currently does not provide any ARM runners 😢 |
That reminds me - I was planning on going through all of the repositories in the LoopVectorization ecosystem to tweak their CI workflows in the same way that we tweaked the workflows in this repository. If you can provide me with a full list of those package names (LoopVectorization.jl, VectorizationBase.jl, etc.), I'll work on tweaking each repo. |
LoopVectorization, VectorizationBase, and SLEEFPirates are the core packages related to SIMD. VectorizationBase.jl also needs a lot more tests. It has <50% coverage at the moment. |
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
- Coverage 92.00% 90.91% -1.10%
==========================================
Files 33 33
Lines 4529 4214 -315
==========================================
- Hits 4167 3831 -336
- Misses 362 383 +21
Continue to review full report at Codecov.
|
It's going to be a lot of noise if we add a bunch of CI jobs that always fail. I think the best approach will be to add these jobs one by one as the bugs get fixed. |
Okay. Was there a report of the failures? |
Yeah you can see all the logs. Go to https://github.com/chriselrod/LoopVectorization.jl/runs/1490884724 And in the left hand side you'll see all the jobs - click a job to open the log. |
@chriselrod Which ArrayInterface.jl should I make PRs to? |
SciML |
I've made several more PRs (to the packages you listed above) to tweak CI. Some tweaks include:
|
I think I got all the packages you specified. Let me know if there are other packages that you'd like me to take a look at. |
I also tried to go through and update the CI workflows for the packages related to ProbabilityModels.jl. Let me know if I missed any packages. |
Before this pull request, we run CI on the following OS+arch combinations:
After this pull request, we run CI on the following OS+arch combinations: