Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsection navigation not present #52

Closed
boydkr opened this issue May 10, 2016 · 5 comments
Closed

Subsection navigation not present #52

boydkr opened this issue May 10, 2016 · 5 comments

Comments

@boydkr
Copy link

boydkr commented May 10, 2016

I see there's a note in the readme about section yielding themselves to get subsection navigation, but it's not clear what that means.

@chrislopresto
Copy link
Owner

@boydkr Can you post some code snippets so we can see what's going on? The examples in the README should work as written.

@boydkr
Copy link
Author

boydkr commented May 10, 2016

I've only gotten as far as installing the add-on and replacing the default fonts in the example template with my own.

I don't get the 'Typography' or 'Colors' subsections.

screen shot 2016-05-10 at 1 32 53 pm

{{#freestyle-section name='Visual Style' as |section|}}

    {{#freestyle-subsection name='Typography' section=section}}

      {{#freestyle-usage 'typography-robotolight' title='Roboto Light'}}
        {{freestyle-typeface fontFamily='robotolight'}}
      {{/freestyle-usage}}

      {{#freestyle-usage 'typography-robotomedium' title='Roboto Medium'}}
        {{freestyle-typeface fontFamily='robotomedium'}}
      {{/freestyle-usage}}

    {{/freestyle-subsection}}

    {{#freestyle-subsection name='Color' section=section}}

      {{#freestyle-usage 'fp' title='Freestyle Palette' usageTitle='Usage'}}
        {{freestyle-palette
            colorPalette=colorPalette
            title='Dummy App Color Palette'
            description='This component displays the color palette specified in freestyle/palette.json'
        }}
      {{/freestyle-usage}}

    {{/freestyle-subsection}}

  {{/freestyle-section}}

  {{#freestyle-section name='Iconography' as |section|}}

    {{#freestyle-subsection name='Icons' section=section}}

    {{/freestyle-subsection}}

  {{/freestyle-section}}

@chrislopresto
Copy link
Owner

Strange. Are you getting any errors in the console? Can you inspect the DOM to see what's actually being rendered in the menu area?

@boydkr
Copy link
Author

boydkr commented May 12, 2016

The submenu elements exist in the DOM, but aren't displayed.

It turns out that we had some wonderful legacy bootstrap css hanging around that was messing with some base elements in the nav 😢 .

Removing the offending css resolves the issue.

@boydkr boydkr closed this as completed May 12, 2016
@chrislopresto
Copy link
Owner

Style guide for the win.. albeit in an indirect fashion here! Glad you tracked it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants