Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for solvers is broken on docs.rs #46

Closed
Coloquinte opened this issue Jan 7, 2024 · 2 comments · Fixed by #47
Closed

Doc for solvers is broken on docs.rs #46

Coloquinte opened this issue Jan 7, 2024 · 2 comments · Fixed by #47

Comments

@Coloquinte
Copy link
Contributor

The solvers are currently built by cloning the corresponding git repository. This does not work with docs.rs, which seems to prohibit network access.

This breaks the build docs.rs for any crate that depends on one of the solvers. I'd like to make it work for my own crates.

@chrjabs
Copy link
Owner

chrjabs commented Jan 11, 2024

Turns out the original PR didn't resolve this, but with #53 it should now be resolved. See the docs for kissat here. (The docs for cadical are still missing, but I think this is only because it tried to pull an old version of one of the other crates and failed for that reason, so with the next release the docs for that should be there as well.)

@Coloquinte
Copy link
Contributor Author

Sorry, it seems that #[cfg(not(doc))] didn't do much actually. I like your fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants