-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Serialize/Deserialize for std::ops::Bound<DateTime>
and friends
#299
Comments
Where does the Either way you ought to be at least partially unblocked by using serde's support for remote crates |
Diesel implements PostgreSQL range data types as
Sure, but it would be great to have such feature right out of the box. |
I agree it would be nice. I think that this feature belongs in diesel, though, since diesel depends on chrono not the other way around. |
I think about that as a support for serialization and deserialization for time ranges in general. Because |
Ah, yes, when you responded that Implementation-wise, that seems straightforward. Currently the A PR that implements that would be very welcome! |
std::ops::Bound<DateTime>
and friends
Yes, I was referring to |
I think, there is no way (and no need, actually) to implement Instead, this PR will allow to ser/de We can close this issue, I guess? |
We still need a few serde helpers (ts_seconds, etc) I believe. |
the serde helpers are only needed for the module helpers, which I don't think will be necessary for interacting with diesel's serde support. I'm going to close this for now in favor of 0nkery's serde patches, but if those don't help enough then we can re-open or open a new, more specific, issue. |
Would be useful for serializing PostgreSQL time range data types:
tsrange
,tstzrange
,daterange
that are already supported by Diesel.The text was updated successfully, but these errors were encountered: