Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0/2.1 Underwater Emitters don't illuminate blocks correctly #528

Closed
jackjt8 opened this issue Jun 3, 2019 · 8 comments · Fixed by #637
Closed

2.0/2.1 Underwater Emitters don't illuminate blocks correctly #528

jackjt8 opened this issue Jun 3, 2019 · 8 comments · Fixed by #637
Labels
bug chunky 2.x Issues that only affect version 2.x of chunky (for Minecraft 1.13+) renderer

Comments

@jackjt8
Copy link
Member

jackjt8 commented Jun 3, 2019

Underwater emitters do not illuminate blocks and only illuminate the water surface. I have yet to test other conditions.

Expected results (1.4.6beta2) -
superflat_1 12_uw_emitters-1024

Results from 2.0beta2 -
superflat_1 13_uw_emitters-1024

Credit to Lohfrum_Faleign for discovering this.

@jackjt8
Copy link
Member Author

jackjt8 commented Jun 3, 2019

I have now tested with the camera above the waters surface, with the emitter being below, and I am seeing the same issue.

[vis 20, opac .1]

Expected results (1.4.6beta2) -
superflat_1 12_uw_emitters2-1024

Results from 2.0beta2 -
superflat_1 13_uw_emitters2-1024

@llbit
Copy link
Collaborator

llbit commented Jun 8, 2019

I tried to reproduce this in 2.0-beta5 but it seems like a glowstone emitter works fine underwater.

@jackjt8
Copy link
Member Author

jackjt8 commented Jun 8, 2019

It appears my initial assessment of the problem was incorrect. After testing 2.0beta5 in real time I noticed that emitters do in fact emit light but it is significantly reduced in both amounts and intensity. This prompted additional testing at 16SPP.

For a camera which is submerged (test 1), it's not just the emitter which are seeing diminished effectiveness, but also the sunlight itself. In the case of the camera being above the water (test 2), sunlight appears to work as normal but the issue with the emitter remains.

Test 1
1.4.6beta2
superflat_1 12_uw_emitters-16_146b2

2.0beta4/5
superflat_1 13_uw_emitters-16_2b5

2.0beta4/5 (increased brightness)
superflat_1 13_uw_emitters-16_2b5+bright (2)

Test 2
1.4.6beta2
superflat_1 12_uw_emitters2-16_146b2

2.0beta4/5
superflat_1 13_uw_emitters2-16_2b4

@jackjt8
Copy link
Member Author

jackjt8 commented Jun 8, 2019

I also decided to generate another 1.12 world with an Ocean Monument and port it into 1.13. I matched the settings otherwise- This time having emitter intensity set to 1000, but I'm certain the same is true for sunlight, I will just test that in a second.

1.4.6beta2
Ocean12-128

2.0beta5
default-128

@jackjt8
Copy link
Member Author

jackjt8 commented Jun 8, 2019

And finally just some testing of the sun light under water. Intensity set to 5.

1.4.6beta2
Ocean12-128_sun

2.0beta5
default-128_sun

@llbit
Copy link
Collaborator

llbit commented Jun 9, 2019

Thanks for the update, I'll continue to investigate. Could you upload the scenes for Test1?

@jackjt8
Copy link
Member Author

jackjt8 commented Jun 9, 2019

Test_1.zip

Certainly. I've also provided the original worlds just in case you would want them.

@jackjt8 jackjt8 changed the title 2.0beta4 Underwater Emitters don't illuminate blocks only water surface 2.0/2.1 Underwater Emitters don't illuminate blocks only water surface Apr 28, 2020
@jackjt8
Copy link
Member Author

jackjt8 commented Apr 28, 2020

Did some additional testing and noticed that for non-flush light sources underwater light propagates at least 1 block in each direction like it does in 1.4.5. Also noteworthy that in this scene, the underside of the water surface is not being lit in 2.X.

1.4.5
NoiseTest_b_1_water_glass-256

2.0beta6
NoiseTest_b_2_water_glass-256

@jackjt8 jackjt8 changed the title 2.0/2.1 Underwater Emitters don't illuminate blocks only water surface 2.0/2.1 Underwater Emitters don't illuminate blocks correctly Apr 28, 2020
@leMaik leMaik added the chunky 2.x Issues that only affect version 2.x of chunky (for Minecraft 1.13+) label May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug chunky 2.x Issues that only affect version 2.x of chunky (for Minecraft 1.13+) renderer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants