From 8b220a40aa19a807089fc5baea2065dd3b507b72 Mon Sep 17 00:00:00 2001 From: Nik Butenko Date: Sun, 6 Aug 2017 15:14:25 +1000 Subject: [PATCH] Make build great again --- .circleci/config.yml | 38 + .editorconfig | 10 + .eslintignore | 4 +- .eslintrc | 333 +---- .gitignore | 8 +- .npmignore | 1 - README.md | 15 +- circle.yml | 16 - {src/example => example}/App/AutoUnmount.js | 2 +- {src/example => example}/App/FixedHeight.js | 21 +- {src/example => example}/App/Hooks.js | 13 +- .../App/InitiallyOpened.js | 5 +- {src/example => example}/App/Issue163.js | 2 +- {src/example => example}/App/Issue40.js | 4 +- {src/example => example}/App/Issue59.js | 2 +- {src/example => example}/App/Issue66.js | 2 +- {src/example => example}/App/Nested.js | 7 +- {src/example => example}/App/SpringConfig.js | 37 +- .../example => example}/App/VariableHeight.js | 13 +- {src/example => example}/App/VariableText.js | 13 +- {src/example => example}/App/index.js | 10 +- {src/example => example}/App/text.json | 0 {src/example => example}/app.css | 0 src/example/Example.js => example/index.js | 9 +- {src/example => example}/react-collapse.gif | Bin {src/example => example}/reset.css | 0 nightwatch.json | 41 - package.json | 82 +- scripts/build.js | 6 + scripts/dev.js | 11 + scripts/dist.js | 16 + scripts/e2e.js | 107 ++ scripts/ghPages.js | 24 + scripts/lib.js | 12 + scripts/lint.js | 8 + scripts/pub.js | 12 + scripts/test.js | 37 + scripts/utils/bash.js | 52 + scripts/utils/ci.js | 50 + scripts/utils/webpack/common.js | 93 ++ scripts/utils/webpack/dev.config.js | 44 + scripts/utils/webpack/dist.config.js | 36 + scripts/utils/webpack/min.config.js | 38 + scripts/utils/webpack/pub.config.js | 49 + test-e2e/Smoketest.js | 12 - test/index.js | 8 - webpack.config.js | 150 -- yarn.lock | 1289 ++++++----------- 48 files changed, 1270 insertions(+), 1472 deletions(-) create mode 100644 .circleci/config.yml create mode 100644 .editorconfig delete mode 100644 .npmignore delete mode 100644 circle.yml rename {src/example => example}/App/AutoUnmount.js (97%) rename {src/example => example}/App/FixedHeight.js (75%) rename {src/example => example}/App/Hooks.js (90%) rename {src/example => example}/App/InitiallyOpened.js (88%) rename {src/example => example}/App/Issue163.js (97%) rename {src/example => example}/App/Issue40.js (88%) rename {src/example => example}/App/Issue59.js (97%) rename {src/example => example}/App/Issue66.js (98%) rename {src/example => example}/App/Nested.js (84%) rename {src/example => example}/App/SpringConfig.js (74%) rename {src/example => example}/App/VariableHeight.js (79%) rename {src/example => example}/App/VariableText.js (83%) rename {src/example => example}/App/index.js (93%) rename {src/example => example}/App/text.json (100%) rename {src/example => example}/app.css (100%) rename src/example/Example.js => example/index.js (69%) rename {src/example => example}/react-collapse.gif (100%) rename {src/example => example}/reset.css (100%) delete mode 100644 nightwatch.json create mode 100755 scripts/build.js create mode 100755 scripts/dev.js create mode 100755 scripts/dist.js create mode 100755 scripts/e2e.js create mode 100755 scripts/ghPages.js create mode 100755 scripts/lib.js create mode 100755 scripts/lint.js create mode 100755 scripts/pub.js create mode 100755 scripts/test.js create mode 100644 scripts/utils/bash.js create mode 100644 scripts/utils/ci.js create mode 100644 scripts/utils/webpack/common.js create mode 100644 scripts/utils/webpack/dev.config.js create mode 100644 scripts/utils/webpack/dist.config.js create mode 100644 scripts/utils/webpack/min.config.js create mode 100644 scripts/utils/webpack/pub.config.js delete mode 100644 test-e2e/Smoketest.js delete mode 100644 test/index.js delete mode 100644 webpack.config.js diff --git a/.circleci/config.yml b/.circleci/config.yml new file mode 100644 index 0000000..025914f --- /dev/null +++ b/.circleci/config.yml @@ -0,0 +1,38 @@ +version: 2 + + +jobs: + build: + working_directory: ~/react-collapse + docker: + - image: circleci/node:8 + - image: selenium/standalone-firefox:3.4.0 + + steps: + - checkout + + + - restore_cache: + key: deps-{{ checksum "yarn.lock" }} + + + - run: yarn install --pure-lockfile + + + - save_cache: + key: deps-{{ checksum "yarn.lock" }} + paths: + - node_modules + + + - run: yarn lint + + + - run: yarn test + + + - run: + name: yarn e2e + command: | + export DOCKER_IP=$(ifconfig | grep "inet addr:" | grep "Bcast:0.0.0.0" | cut -d: -f2 | awk '{ print $1}') + yarn e2e diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 0000000..a7f82a9 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,10 @@ +# editorconfig.org +root = true + +[*] +end_of_line = lf +charset = utf-8 +trim_trailing_whitespace = true +insert_final_newline = true +indent_style = space +indent_size = 2 diff --git a/.eslintignore b/.eslintignore index 837fefc..24c3201 100644 --- a/.eslintignore +++ b/.eslintignore @@ -1,5 +1,5 @@ -/example/ -/lib/ /node_modules/ /build/ +/lib/ +/pub/ /reports/ diff --git a/.eslintrc b/.eslintrc index 78c2c08..977a790 100644 --- a/.eslintrc +++ b/.eslintrc @@ -1,308 +1,37 @@ { - "env": { - "browser": true, - "node": true, - "es6": true - }, - + "extends": "airbnb", "parser": "babel-eslint", - - "plugins": ["react", "babel"], - + "plugins": [ + "babel" + ], "rules": { - // - //Possible Errors - // - // The following rules point out areas where you might have made mistakes. - // - "comma-dangle": 2, // disallow or enforce trailing commas (recommended) - "no-cond-assign": 2, // disallow assignment in conditional expressions (recommended) - "no-console": 2, // disallow use of console (recommended) - "no-constant-condition": 2, // disallow use of constant expressions in conditions (recommended) - "no-control-regex": 2, // disallow control characters in regular expressions (recommended) - "no-debugger": 2, // disallow use of debugger (recommended) - "no-dupe-args": 2, // disallow duplicate arguments in functions (recommended) - "no-dupe-keys": 2, // disallow duplicate keys when creating object literals (recommended) - "no-duplicate-case": 2, // disallow a duplicate case label. (recommended) - "no-empty": 2, // disallow empty block statements (recommended) - "no-empty-character-class": 2, // disallow the use of empty character classes in regular expressions (recommended) - "no-ex-assign": 2, // disallow assigning to the exception in a catch block (recommended) - "no-extra-boolean-cast": 2, // disallow double-negation boolean casts in a boolean context (recommended) - "no-extra-parens": 0, // disallow unnecessary parentheses - "no-extra-semi": 2, // disallow unnecessary semicolons (recommended) (fixable) - "no-func-assign": 2, // disallow overwriting functions written as function declarations (recommended) - "no-inner-declarations": 2, // disallow function or variable declarations in nested blocks (recommended) - "no-invalid-regexp": 2, // disallow invalid regular expression strings in the RegExp constructor (recommended) - "no-irregular-whitespace": 2, // disallow irregular whitespace outside of strings and comments (recommended) - "no-negated-in-lhs": 2, // disallow negation of the left operand of an in expression (recommended) - "no-obj-calls": 2, // disallow the use of object properties of the global object (Math and JSON) as functions (recommended) - "no-regex-spaces": 2, // disallow multiple spaces in a regular expression literal (recommended) - "no-sparse-arrays": 2, // disallow sparse arrays (recommended) - "no-unexpected-multiline": 2, // Avoid code that looks like two expressions but is actually one (recommended) - "no-unreachable": 2, // disallow unreachable statements after a return, throw, continue, or break statement (recommended) - "use-isnan": 2, // disallow comparisons with the value NaN (recommended) - "valid-jsdoc": 2, // Ensure JSDoc comments are valid - "valid-typeof": 2, // Ensure that the results of typeof are compared against a valid string (recommended) - - - // - // Best Practices - // - // These are rules designed to prevent you from making mistakes. - // They either prescribe a better way of doing something or help you avoid footguns. - // - "accessor-pairs": 2, // Enforces getter/setter pairs in objects - "array-callback-return": 2, // Enforces return statements in callbacks of array's methods - "block-scoped-var": 2, // treat var statements as if they were block scoped - "complexity": 0, // specify the maximum cyclomatic complexity allowed in a program - "consistent-return": 2, // require return statements to either always or never specify values - "curly": 2, // specify curly brace conventions for all control statements - "default-case": 2, // require default case in switch statements - "dot-location": [2, "property"], // enforces consistent newlines before or after dots - "dot-notation": 2, // encourages use of dot notation whenever possible - "eqeqeq": 2, // require the use of === and !== - "guard-for-in": 2, // make sure for-in loops have an if statement - "no-alert": 2, // disallow the use of alert, confirm, and prompt - "no-caller": 2, // disallow use of arguments.caller or arguments.callee - "no-case-declarations": 2, // disallow lexical declarations in case clauses (recommended) - "no-div-regex": 2, // disallow division operators explicitly at beginning of regular expression - "no-else-return": 2, // disallow else after a return in an if - "no-empty-function": 2, // disallow use of empty functions - "no-empty-pattern": 2, // disallow use of empty destructuring patterns (recommended) - "no-eq-null": 2, // disallow comparisons to null without a type-checking operator - "no-eval": 2, // disallow use of eval() - "no-extend-native": 2, // disallow adding to native types - "no-extra-bind": 2, // disallow unnecessary function binding - "no-extra-label": 2, // disallow unnecessary labels - "no-fallthrough": 2, // disallow fallthrough of case statements (recommended) - "no-floating-decimal": 2, // disallow the use of leading or trailing decimal points in numeric literals - "no-implicit-coercion": 2, // disallow the type conversions with shorter notations - "no-implicit-globals": 2, // disallow var and named functions in global scope - "no-implied-eval": 2, // disallow use of eval()-like methods - "babel/no-invalid-this": 2, // disallow this keywords outside of classes or class-like objects - "no-iterator": 2, // disallow usage of __iterator__ property - "no-labels": 2, // disallow use of labeled statements - "no-lone-blocks": 2, // disallow unnecessary nested blocks - "no-loop-func": 2, // disallow creation of functions within loops - "no-magic-numbers": 0, // disallow the use of magic numbers - "no-multi-spaces": 2, // disallow use of multiple spaces (fixable) - "no-multi-str": 2, // disallow use of multiline strings - "no-native-reassign": 2, // disallow reassignments of native objects - "no-new": 2, // disallow use of the new operator when not part of an assignment or comparison - "no-new-func": 2, // disallow use of new operator for Function object - "no-new-wrappers": 2, // disallows creating new instances of String,Number, and Boolean - "no-octal": 2, // disallow use of octal literals (recommended) - "no-octal-escape": 2, // disallow use of octal escape sequences in string literals, such as var foo = "Copyright \251"; - "no-param-reassign": 2, // disallow reassignment of function parameters - "no-process-env": 0, // disallow use of process.env - "no-proto": 2, // disallow usage of __proto__ property - "no-redeclare": 2, // disallow declaring the same variable more than once (recommended) - "no-return-assign": 2, // disallow use of assignment in return statement - "no-script-url": 2, // disallow use of javascript: urls. - "no-self-assign": 2, // disallow assignments where both sides are exactly the same (recommended) - "no-self-compare": 2, // disallow comparisons where both sides are exactly the same - "no-sequences": 2, // disallow use of the comma operator - "no-throw-literal": 2, // restrict what can be thrown as an exception - "no-unmodified-loop-condition": 2, // disallow unmodified conditions of loops - "no-unused-expressions": 2, // disallow usage of expressions in statement position - "no-unused-labels": 2, // disallow unused labels (recommended) - "no-useless-call": 2, // disallow unnecessary .call() and .apply() - "no-useless-concat": 2, // disallow unnecessary concatenation of literals or template literals - "no-void": 2, // disallow use of the void operator - "no-warning-comments": 0, // disallow usage of configurable warning terms in comments - e.g. TODO or FIXME - "no-with": 2, // disallow use of the with statement - "radix": 2, // require use of the second argument for parseInt() - "vars-on-top": 2, // require declaration of all vars at the top of their containing scope - "wrap-iife": 2, // require immediate function invocation to be wrapped in parentheses - "yoda": 2, // require or disallow Yoda conditions - - - // - // Strict Mode - // - // These rules relate to using strict mode. - // - "strict": 0, // controls location of Use Strict Directives. 0: required by babel-eslint - - - // - // Variables - // - // These rules have to do with variable declarations. - // - "init-declarations": 0, // enforce or disallow variable initializations at definition - "no-catch-shadow": 2, // disallow the catch clause parameter name being the same as a variable in the outer scope - "no-delete-var": 2, // disallow deletion of variables (recommended) - "no-label-var": 2, // disallow labels that share a name with a variable - "no-restricted-globals": 0, // restrict usage of specified global variables - "no-shadow": 2, // disallow declaration of variables already declared in the outer scope - "no-shadow-restricted-names": 2, // disallow shadowing of names such as arguments - "no-undef": 2, // disallow use of undeclared variables unless mentioned in a /*global */ block (recommended) - "no-undef-init": 2, // disallow use of undefined when initializing variables - "no-undefined": 2, // disallow use of undefined variable - "no-unused-vars": [2, {"argsIgnorePattern": "^_", "varsIgnorePattern": "^_"}], // disallow declaration of variables that are not used in the code (recommended) - "no-use-before-define": 2, // disallow use of variables before they are defined + "arrow-parens": [2, "as-needed"], + "quotes": 0, + "object-curly-spacing": [2, "never"], + "comma-dangle": [2, "never"], + "no-unused-vars": [2, {"varsIgnorePattern": "^_", "argsIgnorePattern": "^_"}], + "no-invalid-this": 0, + "no-confusing-arrow": 0, + "no-console": 0, + "strict": 0, + "global-require": 0, + "lines-around-directive": [2, {"before": "never", "after": "always"}], + "import/no-dynamic-require": 0, + "import/prefer-default-export": 0, + "import/no-extraneous-dependencies": 0, + "babel/new-cap": 2, + "babel/object-curly-spacing": 2, + "babel/no-invalid-this": 2, + "babel/semi": 2, + "jsx-a11y/href-no-hash": 0, + "jsx-a11y/label-has-for": 0, + "react/forbid-prop-types": 0, + "react/jsx-filename-extension": [2, {"extensions": [".js"]}], + "react/jsx-closing-bracket-location": [2, {"nonEmpty": "after-props", "selfClosing": "after-props"}], + "react/jsx-sort-props": 0, + "react/no-multi-comp": 0, + "react/prefer-es6-class": 2, + "react/no-array-index-key": 0 - // - // Node.js and CommonJS - // - // These rules are specific to JavaScript running on Node.js or using CommonJS in the browser. - // - "callback-return": 2, // enforce return after a callback - "global-require": 0, // enforce require() on top-level module scope - "handle-callback-err": 2, // enforce error handling in callbacks - "no-mixed-requires": 2, // disallow mixing regular variable and require declarations - "no-new-require": 2, // disallow use of new operator with the require function - "no-path-concat": 2, // disallow string concatenation with __dirname and __filename - "no-process-exit": 0, // disallow process.exit() - "no-restricted-imports": 0, // restrict usage of specified node imports - "no-restricted-modules": 0, // restrict usage of specified node modules - "no-sync": 2, // disallow use of synchronous methods - // - // Stylistic Issues - // - // These rules are purely matters of style and are quite subjective. - // - "array-bracket-spacing": [2, "never"], // enforce spacing inside array brackets (fixable) - "block-spacing": [2, "always"], // disallow or enforce spaces inside of single line blocks (fixable) - "brace-style": 2, // enforce one true brace style - "camelcase": 2, // require camel case names - "comma-spacing": [2, {"before": false, "after": true}], // enforce spacing before and after comma (fixable) - "comma-style": [2, "last"], // enforce one true comma style - "computed-property-spacing": [2, "never"], // require or disallow padding inside computed properties (fixable) - "consistent-this": [2, "_this"], // enforce consistent naming when capturing the current execution context - "eol-last": 2, // enforce newline at the end of file, with no multiple empty lines (fixable) - "func-names": 0, // require function expressions to have a name - "func-style": 0, // enforce use of function declarations or expressions - "id-blacklist": 0, // blacklist certain identifiers to prevent them being used - "id-length": 0, // this option enforces minimum and maximum identifier lengths (variable names, property names etc.) - "id-match": 0, // require identifiers to match the provided regular expression - "indent": [2, 2, {"SwitchCase": 1}], // specify tab or space width for your code (fixable) - "jsx-quotes": [2, "prefer-double"], // specify whether double or single quotes should be used in JSX attributes (fixable) - "key-spacing": [2, {"beforeColon": false, "afterColon": true}], // enforce spacing between keys and values in object literal properties - "keyword-spacing": [2, {"before": true, "after": true}], // enforce spacing before and after keywords (fixable) - "linebreak-style": [2, "unix"], // disallow mixed 'LF' and 'CRLF' as linebreaks - "lines-around-comment": [2, {"beforeBlockComment": true, "afterBlockComment": false, "afterLineComment": false}], // enforce empty lines around comments - "max-depth": [2, 3], // specify the maximum depth that blocks can be nested - "max-len": [2, 100, 2], // specify the maximum length of a line in your program - "max-nested-callbacks": [2, 3], // specify the maximum depth callbacks can be nested - "max-params": [2, 5], // limits the number of parameters that can be used in the function declaration - "max-statements": 0, // specify the maximum number of statement allowed in a function - "babel/new-cap": [2, {"newIsCap": true, "capIsNew": false}], // require a capital letter for constructors - "new-parens": 2, // disallow the omission of parentheses when invoking a constructor with no arguments - "newline-after-var": 0, // require or disallow an empty newline after variable declarations - "newline-per-chained-call": 0, // enforce newline after each call when chaining the calls - "no-array-constructor": 2, // disallow use of the Array constructor - "no-bitwise": 2, // disallow use of bitwise operators - "no-continue": 2, // disallow use of the continue statement - "no-inline-comments": 2, // disallow comments inline after code - "no-lonely-if": 2, // disallow if as the only statement in an else block - "no-mixed-spaces-and-tabs": 2, // disallow mixed spaces and tabs for indentation (recommended) - "no-multiple-empty-lines": [2, {"max": 2}], // disallow multiple empty lines - "no-negated-condition": 2, // disallow negated conditions - "no-nested-ternary": 2, // disallow nested ternary expressions - "no-new-object": 2, // disallow the use of the Object constructor - "no-plusplus": 2, // disallow use of unary operators, ++ and -- - "no-restricted-syntax": [2, "WithStatement"], // disallow use of certain syntax in code - "no-spaced-func": 2, // disallow space between function identifier and application (fixable) - "no-ternary": 0, // disallow the use of ternary operators - "no-trailing-spaces": 2, // disallow trailing whitespace at the end of lines (fixable) - "no-underscore-dangle": 2, // disallow dangling underscores in identifiers - "no-unneeded-ternary": 2, // disallow the use of ternary operators when a simpler alternative exists - "no-whitespace-before-property": 2, // disallow whitespace before properties - "babel/object-curly-spacing": [2, "never"], // require or disallow padding inside curly braces (fixable) - "one-var": [2, "never"], // require or disallow one variable declaration per function - "one-var-declaration-per-line": 2, // require or disallow an newline around variable declarations - "operator-assignment": [2, "never"], // require assignment operator shorthand where possible or prohibit it entirely - "operator-linebreak": [2, "after"], // enforce operators to be placed before or after line breaks - "padded-blocks": [2, "never"], // enforce padding within blocks - "quote-props": [2, "as-needed"], // require quotes around object literal property names - "quotes": [2, "single"], // specify whether backticks, double or single quotes should be used (fixable) - "require-jsdoc": 0, // Require JSDoc comment - "babel/semi": [2, "always"], // require or disallow use of semicolons instead of ASI (fixable) - "semi-spacing": [2, {"before": false, "after": true}], // enforce spacing before and after semicolons (fixable) - "sort-imports": 0, // sort import declarations within module - "sort-vars": 0, // sort variables within the same declaration block - "space-before-blocks": [2, "always"], // require or disallow a space before blocks (fixable) - "space-before-function-paren": [2, {"anonymous": "always", "named": "never"}], // require or disallow a space before function opening parenthesis (fixable) - "space-in-parens": [2, "never"], // require or disallow spaces inside parentheses (fixable) - "space-infix-ops": 2, // require spaces around operators (fixable) - "space-unary-ops": [2, {"words": true, "nonwords": false}], // require or disallow spaces before/after unary operators (fixable) - "spaced-comment": [2, "always"], // require or disallow a space immediately following the // or /* in a comment - "wrap-regex": 0, // require regex literals to be wrapped in parentheses - // - // ECMAScript 6 - // - // These rules are only relevant to ES6 environments and are off by default. - // - "arrow-body-style": [2, "as-needed"], // require braces in arrow function body - "arrow-parens": [2, "as-needed"], // require parens in arrow function arguments - "arrow-spacing": 2, // require space before/after arrow function's arrow (fixable) - "constructor-super": 2, // verify calls of super() in constructors (recommended) - "generator-star-spacing": [2, "before"], // enforce spacing around the * in generator functions (fixable) - "no-class-assign": 2, // disallow modifying variables of class declarations (recommended) - "no-confusing-arrow": 0, // disallow arrow functions where they could be confused with comparisons - "no-const-assign": 2, // disallow modifying variables that are declared using const (recommended) - "no-dupe-class-members": 2, // disallow duplicate name in class members (recommended) - "no-new-symbol": 2, // disallow use of the new operator with the Symbol object (recommended) - "no-this-before-super": 2, // disallow use of this/super before calling super() in constructors (recommended) - "no-useless-constructor": 2, // disallow unnecessary constructor - "no-var": 2, // require let or const instead of var - "object-shorthand": 2, // require method and property shorthand syntax for object literals - "prefer-arrow-callback": 2, // suggest using arrow functions as callbacks - "prefer-const": 2, // suggest using const declaration for variables that are never modified after declared - "prefer-reflect": 0, // suggest using Reflect methods where applicable - "prefer-rest-params": 2, // suggest using the rest parameters instead of arguments - "prefer-spread": 2, // suggest using the spread operator instead of .apply() - "prefer-template": 2, // suggest using template literals instead of strings concatenation - "require-yield": 2, // disallow generator functions that do not have yield - "template-curly-spacing": 2, // enforce spacing around embedded expressions of template strings (fixable) - "yield-star-spacing": 2, // enforce spacing around the * in yield* expressions (fixable) - // - // eslint-plugin-react - // - // List of supported rules - // - "react/display-name": 0, // Prevent missing displayName in a React component definition - "react/forbid-prop-types": 0, // Forbid certain propTypes - "react/no-danger": 2, // Prevent usage of dangerous JSX properties - "react/no-deprecated": 2, // Prevent usage of deprecated methods - "react/no-did-mount-set-state": 0, // Prevent usage of setState in componentDidMount - "react/no-did-update-set-state": 0, // Prevent usage of setState in componentDidUpdate - "react/no-direct-mutation-state": 2, // Prevent direct mutation of this.state - "react/no-is-mounted": 2, // Prevent usage of isMounted - "react/no-multi-comp": 0, // Prevent multiple component definition per file - "react/no-set-state": 0, // Prevent usage of setState - "react/no-string-refs": 2, // Prevent using string references in ref attribute. - "react/no-unknown-property": 2, // Prevent usage of unknown DOM property (fixable) - "react/prefer-es6-class": 0, // Enforce ES5 or ES6 class for React Components - "react/prefer-stateless-function": 0, // Enforce stateless React Components to be written as a pure function - "react/prop-types": 2, // Prevent missing props validation in a React component definition - "react/react-in-jsx-scope": 2, // Prevent missing React when using JSX - "react/self-closing-comp": 2, // Prevent extra closing tags for components without children - "react/sort-comp": 2, // Enforce component methods order - "react/jsx-wrap-multilines": 2, // Prevent missing parentheses around multilines JSX (fixable) - // - // JSX-specific rules - // - "react/jsx-boolean-value": [2, "always"], // Enforce boolean attributes notation in JSX (fixable) - "react/jsx-closing-bracket-location": [2, {"selfClosing": "after-props", "nonEmpty": "after-props"}], // Validate closing bracket location in JSX - "react/jsx-curly-spacing": [2, "never"], // Enforce or disallow spaces inside of curly braces in JSX attributes (fixable) - "react/jsx-equals-spacing": 2, // Enforce or disallow spaces around equal signs in JSX attributes - "react/jsx-handler-names": [2, {"eventHandlerPrefix": "on", "eventHandlerPropPrefix": "on"}], // Enforce event handler naming conventions in JSX - "react/jsx-indent-props": [2, 2], // Validate props indentation in JSX - "react/jsx-indent": [2, 2], // Validate JSX indentation - "react/jsx-key": 2, // Validate JSX has key prop when in array or iterator - "react/jsx-max-props-per-line": [2, {"maximum": 4}], // Limit maximum of props on a single line in JSX - "react/jsx-no-bind": [2, {"allowArrowFunctions": true}], // Prevent usage of .bind() and arrow functions in JSX props - "react/jsx-no-duplicate-props": [2, {"ignoreCase": true}], // Prevent duplicate props in JSX - "react/jsx-no-literals": 0, // Prevent usage of unwrapped JSX strings - "react/jsx-no-undef": 2, // Disallow undeclared variables in JSX - "react/jsx-pascal-case": 2, // Enforce PascalCase for user-defined JSX components - "react/jsx-sort-prop-types": 0, // Enforce propTypes declarations alphabetical sorting - "react/jsx-sort-props": 0, // Enforce props alphabetical sorting - "react/jsx-tag-spacing": [2, {"closingSlash": "never", "beforeSelfClosing": "always", "afterOpening": "never"}], // Validate spacing before closing bracket in JSX (fixable) - "react/jsx-uses-react": 2, // Prevent React to be incorrectly marked as unused - "react/jsx-uses-vars": 2 // Prevent variables used in JSX to be incorrectly marked as unused } } diff --git a/.gitignore b/.gitignore index 5f019b5..ea796d0 100644 --- a/.gitignore +++ b/.gitignore @@ -7,17 +7,13 @@ pids *.pid *.seed -/build/ - # Dependency directory # https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git /node_modules/ +/build/ /lib/ -/example/ -/.coveralls.yml +/pub/ /reports/ /.eslintcache - -.idea/ diff --git a/.npmignore b/.npmignore deleted file mode 100644 index 0b406f3..0000000 --- a/.npmignore +++ /dev/null @@ -1 +0,0 @@ -/src/example/ diff --git a/README.md b/README.md index 17cc95a..e4ef1f6 100644 --- a/README.md +++ b/README.md @@ -3,8 +3,6 @@ [![Gitter](https://img.shields.io/gitter/room/nkbt/help.svg?style=flat-square)](https://gitter.im/nkbt/help) [![CircleCI](https://img.shields.io/circleci/project/nkbt/react-collapse.svg?style=flat-square&label=nix-build)](https://circleci.com/gh/nkbt/react-collapse) -[![AppVeyor](https://img.shields.io/appveyor/ci/nkbt/react-collapse.svg?style=flat-square&label=win-build)](https://ci.appveyor.com/project/nkbt/react-collapse) -[![Coverage](https://img.shields.io/codecov/c/github/nkbt/react-collapse.svg?style=flat-square)](https://codecov.io/github/nkbt/react-collapse?branch=master) [![Dependencies](https://img.shields.io/david/nkbt/react-collapse.svg?style=flat-square)](https://david-dm.org/nkbt/react-collapse) [![Dev Dependencies](https://img.shields.io/david/dev/nkbt/react-collapse.svg?style=flat-square)](https://david-dm.org/nkbt/react-collapse#info=devDependencies) @@ -36,7 +34,7 @@ Don't forget to manually install peer dependencies (`react`, `react-motion`) if ## Demo -[http://nkbt.github.io/react-collapse/example](http://nkbt.github.io/react-collapse/example) +[http://nkbt.github.io/react-collapse](http://nkbt.github.io/react-collapse) ## Codepen demo @@ -289,7 +287,7 @@ All other props are applied to a container that is being resized. So it is possi Currently is being developed and tested with the latest stable `Node 8` on `OSX`. -To run example covering all `ReactCollapse` features, use `yarn start`, which will compile `src/example/Example.js` +To run example covering all `ReactCollapse` features, use `yarn start`, which will compile `example/Example.js` ```bash git clone git@github.com:nkbt/react-collapse.git @@ -304,12 +302,13 @@ open http://localhost:8080 ## Tests ```bash -yarn test +# to run ESLint check +yarn lint -# to generate test coverage (./reports/coverage) -yarn cov +# to run tests +yarn test -# to run end-to-end smoketest +# to run end-to-end tests yarn e2e ``` diff --git a/circle.yml b/circle.yml deleted file mode 100644 index a3e617e..0000000 --- a/circle.yml +++ /dev/null @@ -1,16 +0,0 @@ -machine: - node: - version: 8 - -dependencies: - override: - - yarn install - -test: - override: - - $(yarn bin)/eslint . - - $(yarn bin)/babel-node $(yarn bin)/isparta cover --report text --report lcov --verbose --dir ${CIRCLE_ARTIFACTS}/coverage --include '**/!(*-test).js' test/index.js - - REPORT_DIR=${CIRCLE_TEST_REPORTS} LOG_DIR=${CIRCLE_ARTIFACTS} yarn e2e - - post: - - cat ${CIRCLE_ARTIFACTS}/coverage/lcov.info | $(yarn bin)/codecov diff --git a/src/example/App/AutoUnmount.js b/example/App/AutoUnmount.js similarity index 97% rename from src/example/App/AutoUnmount.js rename to example/App/AutoUnmount.js index a27ba64..dd19e2e 100644 --- a/src/example/App/AutoUnmount.js +++ b/example/App/AutoUnmount.js @@ -1,6 +1,6 @@ import React from 'react'; import PropTypes from 'prop-types'; -import {UnmountClosed} from '../..'; +import {UnmountClosed} from '../../src'; class Test extends React.PureComponent { diff --git a/src/example/App/FixedHeight.js b/example/App/FixedHeight.js similarity index 75% rename from src/example/App/FixedHeight.js rename to example/App/FixedHeight.js index 06eb931..6235ed7 100644 --- a/src/example/App/FixedHeight.js +++ b/example/App/FixedHeight.js @@ -1,5 +1,5 @@ import React from 'react'; -import {Collapse} from '../..'; +import {Collapse} from '../../src'; export class FixedHeight extends React.PureComponent { @@ -17,7 +17,8 @@ export class FixedHeight extends React.PureComponent {