From 9b980bf71f2f3ab80f35e4ad9a8a38bc95544c93 Mon Sep 17 00:00:00 2001 From: Marco Iorio Date: Mon, 23 Sep 2024 09:05:35 +0200 Subject: [PATCH] multicluster: correctly specify the dst context to clustermes connect Use the correct variable to specify the destination context for the clustermesh connect step, which is otherwise left empty: cilium --context gke... clustermesh connect --destination-context '' Although the workflow is currently working regardless (as the context referring to the second cluster is the default one), that no longer applies when pulling in the latest Cilium CLI changes, as --dst-context has been converted to possibly take a list of contexts. Fixes: f2fba32482e0 ("multicluster: Run cilium-cli inside a container") Signed-off-by: Marco Iorio --- .github/workflows/multicluster.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/multicluster.yaml b/.github/workflows/multicluster.yaml index 615ffbfe81..05186a7884 100644 --- a/.github/workflows/multicluster.yaml +++ b/.github/workflows/multicluster.yaml @@ -239,7 +239,7 @@ jobs: $(kubectl --context "${{ steps.contexts.outputs.cluster2 }}" get svc -n kube-system clustermesh-apiserver -o jsonpath='{.metadata.annotations}') # Connect clusters - cilium --context "${{ steps.contexts.outputs.cluster1 }}" clustermesh connect --destination-context "${CONTEXT2}" + cilium --context "${{ steps.contexts.outputs.cluster1 }}" clustermesh connect --destination-context "${{ steps.contexts.outputs.cluster2 }}" # Wait for cluster mesh status to be ready cilium --context "${{ steps.contexts.outputs.cluster1 }}" clustermesh status --wait