-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supporting Kindle Previewer #463
Comments
Originally posted by @HermesPasser in #371 (comment) |
Sorry for commenting on closed issue, but I was wondering why isn't Kindle Previewer's Kindle gen detected automatically? It seems trivial to just add those path to |
Right now, KCC detects kindlegen if the directory is in the PATH Environment Variable (Windows, Linux, Mac OS). A better support would be to use |
It actually doesn't respect PATH on Mac OS. I know, I spent hours figuring this out when I first use it. The culprit is here: Lines 30 to 32 in c3dad08
Basically if it's frozen (packaged) then KCC overwrite the entire PATH variable on Mac OS. On line 40, it also change the PATH variable for non-frozen path (probably to aid development). Which is why I suggest adding the default Kindlegen path should be trivial. Note that this only apply to the GUI app, since the command line tools doesn't get invoked via kcc.py. Also I don't think invoking Kindle Previewer directly is a good idea. Right now it produce MOBI, yes, but there are no guaranteed that one day it might produce KFX instead. |
OK I'm adding this and reopening the issue. |
Originally posted by @Grauen in #371 (comment)
TODO: adapt README
The text was updated successfully, but these errors were encountered: