Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch "docker-compose" to "docker compose". #54

Closed
2 tasks
felddy opened this issue Apr 12, 2021 · 2 comments · Fixed by #105
Closed
2 tasks

Switch "docker-compose" to "docker compose". #54

felddy opened this issue Apr 12, 2021 · 2 comments · Fixed by #105
Assignees
Labels
documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@felddy
Copy link
Member

felddy commented Apr 12, 2021

💡 Summary

The docker command is now capable of doing the work of docker-compose. This message is now emitted by docker-compose:

❱ docker-compose up
Docker Compose is now in the Docker CLI, try `docker compose up`

Motivation and context

Eventually this will be the way™.

Implementation notes

https://docs.docker.com/compose/cli-command/

I've noticed that the new command is more pedantic about the docker-compose.yml files.
Specifically, it does not permit quoted integers for port numbers.

Acceptance criteria

How do we know when this work is done?

  • all docker-compose references converted to docker compose
  • all included docker-compose.yml files work with new command
@felddy felddy added documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Apr 12, 2021
@felddy felddy self-assigned this Apr 12, 2021
@Chealer
Copy link

Chealer commented May 18, 2021

Greetings,
I have no clue what skeleton-docker is, but having stumbled on this ticket, I would advise you to have a look at the ticket about compose-cli's new message, which indicates that docker compose up in currently in preview, before proceeding with this.

@mcdonnnj
Copy link
Member

mcdonnnj commented Dec 6, 2024

This appears to have been done in #105.

@mcdonnnj mcdonnnj closed this as completed Dec 6, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Skeleton Maintenance Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Development

Successfully merging a pull request may close this issue.

3 participants