Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vjp/use spago #122

Merged
merged 15 commits into from
Jun 3, 2020
Merged

Vjp/use spago #122

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b0c5c50
Add spago to dev dependencies
vanceism7 Jun 1, 2020
c266bff
Setup spago packages
vanceism7 Jun 1, 2020
c1417d4
Fix package.json scripts to use spago
vanceism7 Jun 1, 2020
7452fbc
Update gitignore
vanceism7 Jun 1, 2020
b178fb5
Update circleCi config to cache spago properly
vanceism7 Jun 1, 2020
6c552e9
Delete bower.json. Update spago.dhall with author info
vanceism7 Jun 1, 2020
e4f58c4
Re-add RTS_ARGS back into build-ui command
vanceism7 Jun 1, 2020
b895fd8
Don't need to run `spago install` in postinstall step
vanceism7 Jun 1, 2020
d0d6b03
Use purs bundle instead of spago bundle-app
vanceism7 Jun 2, 2020
c6503dc
Pass RTS_ARGS to `spago build`
vanceism7 Jun 2, 2020
2d99aa3
Add RTS_ARGS to `watch-ui` script
vanceism7 Jun 3, 2020
b66392e
Move explicit npm setup to postinstall
vanceism7 Jun 3, 2020
66307de
Fix dhall packages to use packages from the package set
vanceism7 Jun 3, 2020
335a856
Removed npm i commands from postinstall
vanceism7 Jun 3, 2020
dd0b1b2
install node dependencies of css postinstall
vanceism7 Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"scripts": {
"build-all": "yarn run build-ui && yarn run build-css",
"postinstall": "npm i && cd css && npm i",
"postinstall": "",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The infinite loop was caused by the first npm i && . postinstall only runs after npm i is called so running it from a postinstall will result in an infinite loop.

With a postinstall of "cd css && npm i", you basically end up with:

alias npm i="npm i && cd css && npm i"

With a postinstall of just "npm i", you'd end up with something like:

alias npm i="npm i && npm i && npm i && npm i && npm && ..."

I'm not sure if my example is clear, but

"clean": "rm -rf output .spago node_modules && cd css && rm -rf node_modules",
"build-ui": "yarn run spago build -p \"ui-guide/**/*.purs\" -u \"$RTS_ARGS\" && purs bundle output/*/*.js -o dist/example.js $RTS_ARGS",
"watch-ui": "yarn run spago bundle-app -w -u \"$RTS_ARGS\" --then 'yarn run build-css' -p \"ui-guide/**/*.purs\" --to dist/example.js",
Expand Down