FBCM-5217 [Bugfix] Disabled Typeahead Still Allows Changing Selection #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Before, when a single-value Typeahead is disabled, one can still change the selection by clicking on
Change
button to open the item container and then make a selection there. Fixed by not registeringToggleClick
action on theChange
button (aspan
styled as a button which doesn't supportdisabled
prop) when the Typeahead is disabled.How should this be manually tested?
make
dist/index.html
and go to Typeahead tab (#typeaheads
)Typeaheads - State Variants
section, second example on the left, and click on theChange
button