From 56e236a7a54068f7cb445736c625c9f525e53041 Mon Sep 17 00:00:00 2001
From: "pixeebot[bot]" <104101892+pixeebot[bot]@users.noreply.github.com>
Date: Thu, 9 Jan 2025 03:46:06 +0000
Subject: [PATCH] Modernize and secure temp file creation

---
 .../com/equip/equip/Activities/AccountEditActivity.java    | 7 ++-----
 .../equip/equip/Activities/CreateItemListingActivity.java  | 7 ++-----
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/app/src/main/java/com/equip/equip/Activities/AccountEditActivity.java b/app/src/main/java/com/equip/equip/Activities/AccountEditActivity.java
index 624c7ce..e4a7280 100644
--- a/app/src/main/java/com/equip/equip/Activities/AccountEditActivity.java
+++ b/app/src/main/java/com/equip/equip/Activities/AccountEditActivity.java
@@ -60,6 +60,7 @@
 import com.stripe.android.model.Token;
 import com.stripe.android.view.CardInputWidget;
 import com.stripe.android.view.PaymentMethodsActivity;
+import java.nio.file.Files;
 
 import org.json.JSONException;
 import org.json.JSONObject;
@@ -407,11 +408,7 @@ void handlePhoto(int selection){
                         String timeStamp = new SimpleDateFormat("yyyyMMdd_HHmmss").format(new Date());
                         String imageFileName = "JPEG_" + timeStamp + "_";
                         File storageDir = getExternalFilesDir(Environment.DIRECTORY_PICTURES);
-                        imageFile = File.createTempFile(
-                                imageFileName,  /* prefix */
-                                ".jpg",         /* suffix */
-                                storageDir      /* directory */
-                        );
+                        imageFile = Files.createTempFile(storageDir.toPath(), imageFileName, ".jpg").toFile();
 
                         // Save a file: path for use with ACTION_VIEW intents
                         mPhotoStream = new FileInputStream(imageFile.getAbsolutePath());
diff --git a/app/src/main/java/com/equip/equip/Activities/CreateItemListingActivity.java b/app/src/main/java/com/equip/equip/Activities/CreateItemListingActivity.java
index bdbdd55..a68c0dc 100644
--- a/app/src/main/java/com/equip/equip/Activities/CreateItemListingActivity.java
+++ b/app/src/main/java/com/equip/equip/Activities/CreateItemListingActivity.java
@@ -57,6 +57,7 @@
 import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.InputStream;
+import java.nio.file.Files;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
 import java.util.Date;
@@ -286,11 +287,7 @@ void handlePhoto(int selection) {
                         String timeStamp = new SimpleDateFormat("yyyyMMdd_HHmmss").format(new Date());
                         String imageFileName = "JPEG_" + timeStamp + "_";
                         File storageDir = getExternalFilesDir(Environment.DIRECTORY_PICTURES);
-                        imageFile = File.createTempFile(
-                                imageFileName,  /* prefix */
-                                ".jpg",         /* suffix */
-                                storageDir      /* directory */
-                        );
+                        imageFile = Files.createTempFile(storageDir.toPath(), imageFileName, ".jpg").toFile();
 
                         // Save a file: path for use with ACTION_VIEW intents
                         mPhotoStreams.add(new FileInputStream(imageFile.getAbsolutePath()));