Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch signMessage in keystore to optimize performance #222

Closed
homura opened this issue Apr 17, 2023 · 1 comment · Fixed by #225
Closed

batch signMessage in keystore to optimize performance #222

homura opened this issue Apr 17, 2023 · 1 comment · Fixed by #225
Assignees
Milestone

Comments

@homura
Copy link
Contributor

homura commented Apr 17, 2023

Motivation

The transfer all feature in nexus-demo spent about 1 min to sign a transaction with 30 different locks, we need to support signing message in batch

export interface SignMessagePayload {
/**
* message be to signed
*/
message: BytesLike;
/**
* derivation path of the private key, will be used to sign the message
*/
path: HardenedPath | NonHardenedPath;
/**
* password to decrypt the keystore
*/
password: PasswordProvider;
}

@homura
Copy link
Contributor Author

homura commented Apr 17, 2023

#225 has resolved this issue

@homura homura closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants