Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce editor.status (or state) #2935

Closed
pjasiun opened this issue Mar 13, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-core#132
Closed

Introduce editor.status (or state) #2935

pjasiun opened this issue Mar 13, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-core#132
Assignees
Labels
package:core status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@pjasiun
Copy link

pjasiun commented Mar 13, 2018

We should introduce editor.status observable property, similar to the CKEditor 4: https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_editor.html#property-status

I propose to have the following possible status values:

  • initializing - during initialization chain.
  • ready - after initializing chain, the editor is ready to work.
  • destroyed - after destroy, editor and all plugins are destroyed.

This is important because there is no way to stop promises when the editor is destroyed and some plugins should check the editor status in then.

It can be alternatively called state, both state and status are fine for me. cc @Reinmar

@oskarwrobel oskarwrobel self-assigned this Jun 27, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-core Jun 27, 2018
Feature: Added the observable `Editor#state` property. Closes #124.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-core Oct 9, 2019
@mlewand mlewand added this to the iteration 19 milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:core labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:core status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants