Extend Editor class with debug utils
#200
Conversation
|
|
||
| // @if CK_DEBUG_ENGINE // this.logModel( version ); | ||
| // @if CK_DEBUG_ENGINE // this.logView( version ); | ||
| // @if CK_DEBUG_ENGINE // } |
There was a problem hiding this comment.
I think it would be great to keep all the code related to engine debugging in the ckeditor5-engine module. Not only because it is called CK_DEBUG_ENGINE, but also because the main editor class is kind of the main editor API. Many people will read this code to learn how the editor is created or to debug some problems (not necessarily related to the engine). I think that we should not add such code here since it makes reading this main file harder.
There was a problem hiding this comment.
I think that this.model.document.log( version ); and this.editing.view.document.log( version ); is enough. We do not need these additional methods on the editor. The rest of the code I believe can be moved to the engine.
Suggested merge commit message (convention)
Internal: Extended
Editorclass with debug tools. Part of ckeditor/ckeditor5#5649, ckeditor/ckeditor5-engine#1805.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.