Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG icons should not define own fill if controlled by the styles #2915

Closed
dkonopka opened this issue Apr 20, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-core#80
Closed

SVG icons should not define own fill if controlled by the styles #2915

dkonopka opened this issue Apr 20, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-core#80
Assignees
@oleq
Labels
package:core type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@dkonopka
Copy link
Contributor

We need to change appearance of icons object-center.svg, object-right.svg and low-vision.svg in letters, but in svg code, I see fill="#343434" or fill="#3a3a3a" and I can't overwrite them or change via CSS.

currentColor or delete that property should help.

anyway SVGOMG is cool tool to clear svg.
@Reinmar
Copy link
Member

Reinmar commented Apr 20, 2017

cc @oleq

@oleq oleq changed the title SVG icons with inline fill up SVG icons should not define own fill if controlled by the styles Apr 20, 2017
@oleq oleq self-assigned this Apr 20, 2017
oleq referenced this issue in ckeditor/ckeditor5-core Apr 20, 2017
@oleq
Fix: SVG icons should not define own fill if controlled by the styles…
adb23f3 
…. Closes #79.
@oleq
Copy link
Member

oleq commented Apr 21, 2017

I created a PR, @dkonopka let us know if it fixed your issue.

szymonkups referenced this issue in ckeditor/ckeditor5-core May 11, 2017
@szymonkups
Merge pull request #80 from ckeditor/t/79
fadf5ec 
Fix: SVG icons should not define own fill if controlled by the styles. Closes #79.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-core Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:core labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:core type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/79: SVG icons should not define own fill if controlled by the styles ckeditor/ckeditor5-core
4 participants
@Reinmar @oleq @mlewand @dkonopka