Should model.Writer#setTextData() be removed?

[Reinmar]

I can't see it used... and it shouldn't be used at all because it changes the text node's data directly:

	/**
	 * Sets the text content for the specified `textNode`.
	 *
	 * @param {String} value New value.
	 * @param {module:engine/model/text~Text} textNode Text node that will be updated.
	 */
	setTextData( value, textNode ) {
		textNode._data = value;
	}

[pjasiun]

https://github.com/ckeditor/ckeditor5-list/blob/d2023267caa88eb383b1fab773e137c233cf5b8d/src/converters.js#L456

https://github.com/ckeditor/ckeditor5-list/blob/d2023267caa88eb383b1fab773e137c233cf5b8d/src/converters.js#L461

[Reinmar]

OK, but this can be done only in a veeeery specific situation – on detached nodes. Am I right? You must not do such changes on text nodes which were already inserted into the document or are in the graveyard.

[pjasiun]

This is the view writer, and I believe it should work allways. You should usually not change view without changes in the model, but it is a different topic.

[Reinmar]

It's the view writer? In upcast converters? I'm a bit lost. I was talking about the model writer which also has the setTextData() method.

[pjasiun]

Ach, I agree then. Model writer should not have this method.