Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to pass attribute style="value" to model by model utils and datacontroller #3795

Closed
oskarwrobel opened this issue Aug 9, 2016 · 5 comments
Labels
package:engine resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oskarwrobel
Copy link
Contributor

When we want to set attribute style with some custom value style="dark" to model element then view conversion cuts it off https://github.com/ckeditor/ckeditor5-engine/blob/fc7da8035cdc9533f66ad5de66711e25cd2b385e/src/view/element.js#L103-L107

@oskarwrobel oskarwrobel changed the title Is not possible to pass attribute style="value" to model by model utils and datacontroller It is not possible to pass attribute style="value" to model by model utils and datacontroller Aug 9, 2016
@pjasiun
Copy link

pjasiun commented Aug 9, 2016

Note that we will have this problem with any data processor other then HTML. On the editor.setData we parse the data to the "view" structure, and it assume that it is HTML-like (so parse styles and classes in the special way).

@pjasiun
Copy link

pjasiun commented Aug 9, 2016

On the other hand in might be a correct behavior. Plugins which introduce converters assume that view is HTML-like, so data processors should not create invalid structure.

@szymonkups
Copy link
Contributor

This made us name model attribute used by ImageStyle plugin as imageStyle instead of just style. We should try to fix this before 1.0.0.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the unknown milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@pomek pomek removed this from the unknown milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

6 participants