Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename attachPlaceholder to something more humanly #4034

Closed
Reinmar opened this issue Mar 30, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1644
Closed

Rename attachPlaceholder to something more humanly #4034

Reinmar opened this issue Mar 30, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1644
Assignees
@oleq
Labels
package:engine
Milestone
iteration 22

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 30, 2017

We're not attaching the placeholder. You attach a poster to a wall. We could either use a simple addPlaceholder() or enablePlaceholder().
@oleq
Copy link
Member

oleq commented Jan 16, 2019

I think it's time we handled it in #479.

@oleq oleq self-assigned this Jan 16, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-engine Feb 7, 2019
Merge pull request #1644 from ckeditor/t/ckeditor5/479
21dee6b 
Feature: Moved the root element DOM attributes management from the UI to the engine. Made it possible to use `addPlaceholder()` (now `enablePlaceholder()`) on the root editable. Introduced the `View.detachDomRoot()` method. Implemented additional placeholder helpers (`showPlaceholder()`, `hidePlaceholder()`, `needsPlaceholder()`) (see ckeditor/ckeditor5#479). Closes #899.

BREAKING CHANGE: The `attachPlaceholder()` has been renamed to `enablePlaceholder()`.
BREAKING CHANGE: `enablePlaceholder()` accepts a configuration object instead of separate parameters.
BREAKING CHANGE: The `detachPlaceholder()` has been renamed to `disablePlaceholder()`.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:engine
Projects
None yet
Milestone
iteration 22
3 participants
@Reinmar @oleq @mlewand