Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font family not working together with font size #2280

Closed
Tlapi opened this issue Mar 19, 2018 · 5 comments
Closed

Font family not working together with font size #2280

Tlapi opened this issue Mar 19, 2018 · 5 comments
Assignees
Labels
package:font type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Tlapi
Copy link

Tlapi commented Mar 19, 2018

Using this plugin when I select both font-size and font family, it results to:

<span class="text-huge" style="font-family:Bitter, Georgia, serif;">test</span>

That is OK

But when CKeditor loads this, it removes font-family style.

However when you do not choose font size and load this, it works good:
<span style="font-family:Bitter, Georgia, serif;">test</span>

@Reinmar
Copy link
Member

Reinmar commented Mar 19, 2018

cc @jodator

@jodator
Copy link
Contributor

jodator commented Mar 20, 2018

Yes we are aware of this problem. However we need to fix this at engine level: https://github.com/ckeditor/ckeditor5-engine/issues/1348.

@jodator
Copy link
Contributor

jodator commented Mar 27, 2018

I'm closing this as https://github.com/ckeditor/ckeditor5-engine/issues/1348 is closed. The issue was fixed at the engine level:

selection_025

@jodator jodator closed this as completed Mar 27, 2018
@jodator jodator reopened this Mar 27, 2018
@jodator
Copy link
Contributor

jodator commented Mar 27, 2018

I've forgot to update the font definitions.

@jodator
Copy link
Contributor

jodator commented Mar 27, 2018

Ugh.. again sorry. I've just forgot to rebuild the decoupled editor build before testing it.

It works as supposed without touching the font conversion definitions.

@jodator jodator closed this as completed Mar 27, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-font Oct 8, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:font labels Oct 8, 2019
@mlewand mlewand added this to the iteration 15 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:font type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants