Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dropdown list could have a more consistent spacing #2438

Closed
Reinmar opened this issue Mar 13, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-heading#67
Closed

The dropdown list could have a more consistent spacing #2438

Reinmar opened this issue Mar 13, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-heading#67
Assignees
Labels
package:heading type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 13, 2017

This is how it looks like now:

image

When I first saw this life after the recent changes I thought that some styles didn't refresh.

  • First I noticed very small vertical spacing at the start and end of the list.
  • Then I thought that even though the font sizes are different, the items should take the equal height (that's the case in Google Docs for example).
  • Finally, when none of the items is selected, the space on the left looks like a bug too ;|. It looks better with at least one item selected, though:

image

BTW. Check the formats and font family and font size dropdowns in Google Drive :) Interesting that they use all 3 types. The first has a check mark even though only one item can be selected at a time. The second use no marker. The second has check marks and more than one item can be selected at once. The last one has no check marks and only one item can be selected.

Anyway, even if the space on the left is ok, the inconsistent vertical spacing seems to be an issue still.

@oleq oleq self-assigned this Mar 14, 2017
oleq referenced this issue in ckeditor/ckeditor5-heading Mar 15, 2017
szymonkups referenced this issue in ckeditor/ckeditor5-heading Mar 16, 2017
Other: Introduced consistent height and spacing among headings dropdown items. Closes #63.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-heading Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:heading labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:heading type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants