Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot easily remove part of highlight #2600

Closed
Reinmar opened this issue Mar 9, 2018 · 4 comments
Closed

Cannot easily remove part of highlight #2600

Reinmar opened this issue Mar 9, 2018 · 4 comments
Labels
package:highlight resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 9, 2018

  1. Open http://localhost:8125/ckeditor5-highlight/tests/manual/highlight.html.
  2. Select a part of yellow highlight (e.g. "low").
  3. Press the highlight button (which should be on by now).

Expected: the highlight was removed from the selected text.

Actual: nothing happened.

cc @oleq @dkonopka do you agree with "expected"?

@Reinmar
Copy link
Member Author

Reinmar commented Mar 9, 2018

Also, it made me realise that my expectations regarding how the highlight will react kinda negate https://github.com/ckeditor/ckeditor5-link/issues/173. I was indeed expecting that something will happen when I press the button.

@oleq
Copy link
Member

oleq commented Mar 12, 2018

The highlight has no UI like the link, so the behaviors can differ. Yes, it feels like this feature is missing — the selected part of the HL should be removed.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-highlight Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:highlight labels Oct 9, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 3, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:highlight resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants