Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight does not work well with font size #2605

Closed
oskarwrobel opened this issue Mar 12, 2018 · 1 comment
Closed

Highlight does not work well with font size #2605

oskarwrobel opened this issue Mar 12, 2018 · 1 comment
Assignees
@pomek
Labels
package:highlight type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 18

Comments

@oskarwrobel
Copy link
Contributor

image

Looks like a matter of conversion priorities.

image
@pomek
Copy link
Member

pomek commented Apr 18, 2018

https://github.com/ckeditor/ckeditor5-engine/issues/1408 will help resolve this issue.

Reinmar referenced this issue in ckeditor/ckeditor5-font May 15, 2018
@Reinmar
Merge pull request #16 from ckeditor/t/ckeditor5-highlight/17
3b8b6dc 
Fix: Ensured that font size's and font family's markup is always "outside" markup of other typical inline features, especially those changing background color. Thanks to that, the entire area of styled text will be correctly colored. Closes ckeditor/ckeditor5-highlight#17.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-highlight Oct 9, 2019
@mlewand mlewand added this to the iteration 18 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:highlight labels Oct 9, 2019
@pomek pomek mentioned this issue Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:highlight type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 18
Development

Successfully merging a pull request may close this issue.

Highlight works fine with the font size plugin ckeditor/ckeditor5-highlight
3 participants
@oskarwrobel @pomek @mlewand