Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text alternative balloon should be displayed as read-only when command is disabled #5108

Closed
oskarwrobel opened this issue Jul 6, 2017 · 3 comments
Closed

Text alternative balloon should be displayed as read-only when command is disabled #5108

oskarwrobel opened this issue Jul 6, 2017 · 3 comments
Labels
package:image resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@oskarwrobel
Copy link
Contributor

When ImageTextAlternativeCommand is disabled user should have access to the alternative text but should not be able to modify it.
@oskarwrobel oskarwrobel self-assigned this Jul 6, 2017
@fredck
Copy link
Contributor

fredck commented Jul 7, 2017

I'm for not showing contextual toolbars at all, if the editor is readonly.

@pjasiun
Copy link

pjasiun commented Jul 7, 2017

@fredck tell it here: https://github.com/ckeditor/ckeditor5-ui/issues/269 ;)

@oleq
Copy link
Member

oleq commented Jul 13, 2017

I'm closing this issue due to lack of discussion. I consider rejecting this PR the right decision and I'm moving the discussion to the somehow related https://github.com/ckeditor/ckeditor5-ui/issues/269.

@oleq oleq closed this as completed Jul 13, 2017
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:image labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:image resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added read-only mode to the ImageTextAlternative. ckeditor/ckeditor5-image
5 participants
@fredck @oskarwrobel @oleq @pjasiun @mlewand