Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link should have higher priority than all other attribute elements #4791

Closed
Reinmar opened this issue May 15, 2017 · 4 comments · Fixed by ckeditor/ckeditor5-link#127
Closed

Link should have higher priority than all other attribute elements #4791

Reinmar opened this issue May 15, 2017 · 4 comments · Fixed by ckeditor/ckeditor5-link#127
Assignees
@oleq
Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented May 15, 2017

In other words: <a> should be never split by applying other styles.

may-15-2017 17-29-23

This can be prevented by giving the link view element's a higher priority (cc @pjasiun, @scofalik, @szymonkups – how to do that?). Of course, unless something is broken in the view writer ;)
@pjasiun
Copy link

pjasiun commented May 15, 2017 •
edited
Loading

Higher priority in the converter should solve the issue. See https://github.com/ckeditor/ckeditor5-engine/blob/cb18a9560cd2ec25f031ae67d7738f8b67747348/src/conversion/buildmodelconverter.js#L188

@oleq oleq self-assigned this Jun 1, 2017
oleq referenced this issue in ckeditor/ckeditor5-link Jun 1, 2017
@oleq
Fix: Link should have higher priority than all other attribute elemen…
a295641 
…ts. Closes #121.
@oleq
Copy link
Member

oleq commented Jun 1, 2017

It turned out that withPriority() didn't work in this case. What worked was a custom priority for LinkElement, which inherits from AttributeElement.

oskarwrobel referenced this issue in ckeditor/ckeditor5-link Jun 13, 2017
@oskarwrobel
Merge pull request #127 from ckeditor/t/121
9dc8973 
Fix: Link should have higher priority than all other attribute elements. Closes #121.
@scofalik
Copy link
Contributor

Why it didn't work? Maybe we should modify converter builder?

@pjasiun
Copy link

pjasiun commented Jun 13, 2017

Because withPriority set the priority of the event, not the priority of the attribute element. We should definitely simplify it.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/121: Link should have higher priority than all other attribute elements ckeditor/ckeditor5-link
5 participants
@Reinmar @oleq @pjasiun @scofalik @mlewand