From f0ac362607e0c4b88b303ca519582843242d2505 Mon Sep 17 00:00:00 2001 From: Mateusz Samsel Date: Mon, 20 May 2019 13:55:58 +0200 Subject: [PATCH 1/4] Fix target value used in links. --- src/mediaregistry.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mediaregistry.js b/src/mediaregistry.js index f3e9aee..3699d6d 100644 --- a/src/mediaregistry.js +++ b/src/mediaregistry.js @@ -298,7 +298,8 @@ class Media { tag: 'a', attributes: { class: 'ck-media__placeholder__url', - target: 'new', + target: '_blank', + rel: 'noopener noreferrer', href: this.url }, children: [ From d88184a5c98c8c8620e04e6b30cd3243e04926eb Mon Sep 17 00:00:00 2001 From: Mateusz Samsel Date: Thu, 23 May 2019 16:24:56 +0200 Subject: [PATCH 2/4] Prevent of opening links of not selected media embed. --- theme/mediaembed.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/theme/mediaembed.css b/theme/mediaembed.css index ffda972..e2a60fc 100644 --- a/theme/mediaembed.css +++ b/theme/mediaembed.css @@ -19,3 +19,7 @@ from being "squashed" in tight spaces, e.g. in table cells (#44) */ min-width: 15em; } + +.ck-editor__editable:not( .ck-read-only ) .ck-widget:not( .ck-widget_selected ) .ck-media__placeholder { + pointer-events: none; +} From f3c2e410ec0d8e9602b5a387c74939c6b6a46add Mon Sep 17 00:00:00 2001 From: Mateusz Samsel Date: Thu, 23 May 2019 16:35:21 +0200 Subject: [PATCH 3/4] Fix unit test to cover new link's attributes. --- tests/mediaembedediting.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/mediaembedediting.js b/tests/mediaembedediting.js index 7c06982..4054c91 100644 --- a/tests/mediaembedediting.js +++ b/tests/mediaembedediting.js @@ -927,7 +927,7 @@ describe( 'MediaEmbedEditing', () => { ']+>' + '