Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell post-fixer should refresh a cell only when it is needed #3283

Closed
scofalik opened this issue Aug 21, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-table#212
Closed

Cell post-fixer should refresh a cell only when it is needed #3283

scofalik opened this issue Aug 21, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-table#212
Assignees
@scofalik
Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 27 (v15...

Comments

@scofalik
Copy link
Contributor

At the moment, the new cell post-fixer is pretty loose/naive. It checks only if something changed just inside a table cell and, if so, it refreshes the table cell. It would be better if it fixed only when really needed.

The way it is now is that it causes unnecessary cell refreshes when an image is uploaded, after each uploadStatus attribute change. This (together with another mistake) causes a serious bug.

To avoid unnecessary changes (and loops through Differ) and avoid bugs in future, the post-fixer should have a better condition applied.
@scofalik scofalik self-assigned this Aug 21, 2019
scofalik referenced this issue in ckeditor/ckeditor5-table Aug 22, 2019
@scofalik
Merge pull request #212 from ckeditor/t/209
b29a042 
Fix: Table cell post-fixer will refresh a cell only when it is needed. Closes #209.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:table labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 27 (v15.0.0)
2 participants
@scofalik @mlewand